Unlock GIL while creating container #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@Consolatis looks like this needs a quick rebase :) |
Signed-off-by: Consolatis <35009135+Consolatis@users.noreply.github.com>
Consolatis
force-pushed
the
fix/allow_threads_create
branch
from
18368cd to
a869854
Compare
Contributor
Author
Still not 100% sure if it's fine to use Py_{True,False} without GIL but branch is rebased |
Member
|
I'd think it's fine, it's just a simple assignment, it doesn't mess with any shared memory with Python or calls any function. |
Contributor
Author
|
Thank you for your quick feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty useful if running .create() in a thread, either manually or via asyncio run_in_executor()
I am not 100% sure if it's ok to release the GIL while using Py_{True,False}. It should be fine as Py_INCREF() comes later.
If there are any doubts I could change this to use a temporary return var and have the check after Py_END_ALLOW_THREADS.