-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proc_fuse: add psi(pressure stall information) procfs #665
Conversation
Hey @loyou, thanks for working on this. Please, notice that you have a failing test https://github.com/lxc/lxcfs/actions/runs/11809711932/job/32900481717?pr=665 |
I'm a little confused with the test result,
the failed line number does not match the patched file lines, |
dir_filler(filler, buf, "swaps", 0) != 0 || | ||
dir_filler(filler, buf, "loadavg", 0) != 0 || | ||
dir_filler(filler, buf, "slabinfo", 0) != 0 || | ||
dirent_filler(filler, path, "pressure", buf, 0) != 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested this, but it looks like if the host does not have /proc/pressure, lxcfs will have a /proc/pressure though it will be empty. I don't know whether that matters, especially as noone directly mounts /var/lib/lxcfs/proc into the container.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Will wait briefly to see whether @mihalicyn had any more comments before merging. |
Going to do a quick rebase on this one so it triggers the new tests we have. |
Kernel support psi(pressure stall information) since 4.20 with procfs /proc/pressure/{io,cpu,memory} and cgroupv2 {io.pressure, cpu.pressure, memory.pressure}. This patch add read-only psi procfs, and people can get pressure information now. Full functional feature for monitoring are still under investigation. Signed-off-by: Feng Sun <loyou85@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Kernel support psi(pressure stall information) since 4.20
with procfs /proc/pressure/{io,cpu,memory} and
cgroupv2 {io.pressure, cpu.pressure, memory.pressure}.
This patch add read-only psi procfs,
and people can get pressure information now.
Full functional feature for monitoring are still under investigation.