Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incus/profile: Add support for creating profile from yaml #756

Merged

Conversation

awalvie
Copy link
Contributor

@awalvie awalvie commented Apr 16, 2024

Ref: #741

@awalvie awalvie requested a review from stgraber as a code owner April 16, 2024 08:05
@awalvie awalvie force-pushed the issue-741--add-yaml-support-for-profile-create branch from 7c6ad12 to f079bd4 Compare April 16, 2024 08:09
awalvie and others added 2 commits April 16, 2024 15:10
Part of lxc#741

Signed-off-by: Vishesh Agrawal <agrawal.vishesh.178@gmail.com>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
@stgraber stgraber force-pushed the issue-741--add-yaml-support-for-profile-create branch from f079bd4 to d09c2e9 Compare April 16, 2024 19:10
@stgraber
Copy link
Member

I updated the commit title a bit and aligned the commit author with the Signed-off-by line so the test should clear now. I also added the make i18n result to a i18n: Update translation templates commit which should then clear the rest of the failures.

Assuming tests behave now, I'll merge this and you can repeat much of the same with the remaining commands, thanks!

@awalvie
Copy link
Contributor Author

awalvie commented Apr 16, 2024

I updated the commit title a bit and aligned the commit author with the Signed-off-by line so the test should clear now. I also added the make i18n result to a i18n: Update translation templates commit which should then clear the rest of the failures.

Thank you! I'll take care of them in the follow-up PRs.

@stgraber stgraber changed the title cmd/profile: Add support for creating profile from yaml incus/profile: Add support for creating profile from yaml Apr 16, 2024
@stgraber stgraber merged commit 045cc70 into lxc:main Apr 16, 2024
25 checks passed
@awalvie awalvie deleted the issue-741--add-yaml-support-for-profile-create branch April 18, 2024 08:22
tomponline added a commit to canonical/lxd that referenced this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants