fix: use genisoimage when mkisofs is not found #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bketelsen
force-pushed
the
genisoimage
branch
from
961a51d
to
89edc66
Compare
Signed-off-by: Brian Ketelsen <bketelsen@gmail.com>
|
Thanks, I've applied the suggestion and changed the commit title, just going to let some tests run through and then I'll merge this. |
stgraber
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fedora variants don't include
mkisofs, but do includegenisoimagewhich is a command compatible substitute. This change checks forgenisoimageand uses ifmkisofsisn't found.