incusd/storage: fix squashfs unpacking to NFS destinations #2148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NFS4v2 supports user.xattr, and can be used with Incus via the dir driver, but image unpacking will fail when the container image uses non-user xattrs such as security.xattr This fix will skip extraction of security.xattrs when extracting to an NFS hosted directory The fix is not specific to the dir driver, and could benefit a future NFS driver too. Signed-off-by: Stuart Espey <stuart.espey@mactrix.com>
mrstux
force-pushed
the
se/fix-unsquashfs-nfs
branch
from
2ba79d2 to
3d6b713
Compare
|
Superseded by #2149. I'd normally push minor fixes directly to the branch but that doesn't typically work when the origin repository belongs to an organization (as is the case here with truenas). |
|
Ah, thanks for this fix. It's what originally pushed me to look at an nfs storage driver. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NFS4v2 supports user.xattrs, and can be used with Incus via the dir driver, but image unpacking will fail when the container image uses non-user xattrs such as security.xattr
This fix will skip extraction of security.xattrs when extracting to an NFS hosted directory
The fix is not specific to the dir driver, and could benefit a future NFS driver (#2025)
In my testing, privileged containers can successfully be started from NFS hosted dir storage pools.