Skip to content

ported network_peers to database generator #2084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

oronila
Copy link

@oronila oronila commented May 7, 2025

#1801 Completed the port. This is my first ever pull request to a open source repo so feel free to let me know if there are issues.

Some things to note are that although most of the methods were portable some required larger chunks of code and particularly, CreateNetworkPeer was extremely long so I left the db/network_peers.go file with the updated call sites for the SQL code as a helper function.

@oronila oronila requested a review from stgraber as a code owner May 7, 2025 00:06
oronila added 2 commits May 29, 2025 13:21
Signed-off-by: Noor Ali <noormehdiali@gmail.com>
Signed-off-by: Noor Ali <noormehdiali@gmail.com>
@stgraber stgraber force-pushed the stable-test-final-pr branch from d3c679a to 4652a05 Compare May 29, 2025 17:22
@stgraber stgraber added this to the incus-6.14 milestone May 29, 2025
@stgraber
Copy link
Member

I did a few tweaks on this one but I'm out of time to get this into today's release so it will go onto next month's.

The PR was missing one pretty important change, the removal of the old functions.
Once I did that, things mostly behaved but it's missing a compatible implementation of the Create logic. Getting the basics done is pretty straightforward but getting the peering+linking logic to match the old logic, that's a bit harder and not something I want to rush in hours before a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants