Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't block cluster upgrades on API additions only #999

Closed
stgraber opened this issue Jul 15, 2024 · 0 comments
Closed

Don't block cluster upgrades on API additions only #999

stgraber opened this issue Jul 15, 2024 · 0 comments
Assignees
Labels
Easy Good for new contributors Feature New feature, not a bug
Milestone

Comments

@stgraber
Copy link
Member

Currently when a clustered server is upgraded, it will wait for all other servers to match its exact setup if it detects that it's ahead of the cluster on either the database schema or the API version (count of API extensions).

Now this is absolutely critical for the database case as we can't have servers accessing a DB schema they can't handle, but the same isn't true for API extensions as those are used to indicate new API features or config keys that are available.

Instead what we should do is fetch the highest common API extension number for the cluster and use that to truncate the API extension list exposed to clients. Basically having a cluster report the API extension list of its oldest (by version) member.

The cluster member status for any server that's behind should reflect that it needs immediate upgrading though.

@stgraber stgraber added Feature New feature, not a bug Easy Good for new contributors labels Jul 15, 2024
@stgraber stgraber added this to the incus-6.4 milestone Jul 15, 2024
@stgraber stgraber self-assigned this Jul 15, 2024
@hallyn hallyn closed this as completed in 1bbcc63 Jul 19, 2024
stgraber added a commit that referenced this issue Jul 19, 2024
Closes #999

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy Good for new contributors Feature New feature, not a bug
Development

No branches or pull requests

1 participant