kconfig for lvgl_esp32_drivers/lvgl_i2 causes ESP-IDF SDK Configuration Editor to Crash

[wreyford]

I've updated to the latest master of lvgl_esp32_drivers.
I'm using LVGL8.3 master.

I can select i2C port Zero, but in the KConfig specific to I2C Port Settings,
if I select Enable I2C port 0 or Enable I2C port 1, instead of bringing up the options to set the pins etc, it just crashes menuconfig.

Please, I don't know how to set my pins.

Also, when including this line of code as per the readme before calling lv_init():

lvgl_i2c_locking(i2c_manager_locking()); 

I get the following compiler error:

implicit declaration of function 'i2c_manager_locking'; did you mean 'i2c_master_write'? [-Werror=implicit-function-declaration]

[wreyford]

In the sdkconfig, the following [ CONFIG_LV_I2C=y and CONFIG_LV_I2C_DISPLAY_PORT=0] appears to be set, but it is not selected anywhere in menuconfig:

# CONFIG_LV_DISP_BACKLIGHT_OFF is not set
CONFIG_LV_DISP_BACKLIGHT_SWITCH=y
# CONFIG_LV_DISP_BACKLIGHT_PWM is not set
# CONFIG_LV_BACKLIGHT_ACTIVE_LVL is not set
CONFIG_LV_DISP_PIN_BCKL=-1
CONFIG_LV_I2C=y
CONFIG_LV_I2C_DISPLAY_PORT=0
# end of LVGL TFT Display controller

and in the kconfig file for lvgl_esp32_drivers/lvgl_tft/kconfig:

line 996

config LV_I2C
        bool
        default y if LV_I2C_DISPLAY

    config LV_I2C_DISPLAY_PORT
        int
        default 1 if LV_I2C_DISPLAY_PORT_1
        default 0

And at line
177

 # Display controller communication protocol
    #
    # This symbols define the communication protocol used by the
    # ESP32 to communicate with the display controller.
    # This symbols can be used, but not limited, to:
    # - Know what peripherals to initialize.
    # - Know if the touch and display controllers share the same peripheral.
    # - Etc.
    config LV_TFT_DISPLAY_PROTOCOL_SPI
        bool
        help
            Display controller protocol SPI

    config LV_I2C_DISPLAY
        bool
        help
            Display controller protocol I2C

But I'm using the ILI9488, and thus

config LV_TFT_DISPLAY_USER_CONTROLLER_ILI9488
        bool "ILI9488"
            select LV_TFT_DISPLAY_CONTROLLER_ILI9488
            select LV_TFT_DISPLAY_PROTOCOL_SPI

but this does not exclusively set SPI, so LV_I2C=y is also set????

[wreyford]

I resorted to screen recording the error that flashes on the screen momentarily in VSCode using the ESP-IDF plugin, when the menuconfig crashes.
The error was a result of the int value not having a default, and thus ''
Fixing this allowed for the proper menuconfig handling of the I2C ports

if I2C_MANAGER_0_ENABLED
		config I2C_MANAGER_0_SDA
			int "SDA (GPIO pin)"
			default 0
		config I2C_MANAGER_0_SCL
			int "SCL (GPIO pin)"
			default 0

and this change is required for both ports 0 and 1.

Now all I need to do is get past the
implicit declaration of function 'i2c_manager_locking'; did you mean 'i2c_master_write'? [-Werror=implicit-function-declaration] error

[tore-espressif]

@ropg could you please have a look?

[ropg]

Will do as soon as I find some time.

[ropg]

Hello there. Sorry it took a while for me to get back here.

This bit:

lvgl_i2c_locking(i2c_manager_locking()); 

Is only for when you additionally install I2C manager as a separate component so that it can be used by things (either your own code or someone else's) outside of LVGL that need access to the I2C bus. This then serves to tell the I2C Manager that is built into LVGL to play nice with (== use the same locking as) the things that use the I2C Manager component. I'll see to make this clearer in the documentation.

As for the missing default: that never made trouble with me, but we'll add that. Thanks!

[ropg]

@wreyford or maintainers, I believe this issue to be fixed.

[C47D]

Ok, let's close this, feel free to open it again if you have issues.