Skip to content

Remove Extra component dirs definition #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2021

Conversation

tore-espressif
Copy link
Collaborator

@tore-espressif tore-espressif commented Feb 24, 2021

Latest lvgl_esp32_drivers changes its component structure. This project has to be updated for it.

TODOs:

@tore-espressif
Copy link
Collaborator Author

@C47D
Would you know why this construct is used throughout the code, when we always use the simple_include variant?

Is there a place somewhere where we don't use it?

#ifdef LV_LVGL_H_INCLUDE_SIMPLE
#include "src/lv_core/lv_refr.h"
#else
#include "lvgl/src/lv_core/lv_refr.h"
#endif

@C47D
Copy link
Collaborator

C47D commented Feb 24, 2021

@tore-espressif AFAIK, it's used so the users can or not enable the simple_include variant on their projects.
I've updated the lvgl_esp32_drivers submodule on the master branch, is there anything else to do before making this PR ready to merge?

@tore-espressif tore-espressif marked this pull request as ready for review February 24, 2021 15:03
@C47D C47D merged commit f2e80cb into lvgl:master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants