-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the example program buildable. #26
Conversation
Modify the example program, demo_jpg_sjpg, so that it will compile and link. Doing this will make it easier to detect required changes when LVGL is changed, as well as function as a simple test program for this project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this should probably be wrapped in an #if LV_LIB_SJPG_TEST
guard, to prevent this main
from being linked into real applications?
The upcoming CMakeLists.txt will create a library for this project, so desktop apps won't even be including this file, and I'm pretty sure that a ESP-IDF build won't include this either. Maybe you're thinking of lv_demos, which have no main(), and are included elsewhere? I'm happy to add the |
Just noticed I confused lv_demos and lv_examples, but still am curious how this would be used. |
E.g. I use Eclipse that automatically collects all the C files. Therefore there would be 2 |
That makes sense. I'll upload a new version.
…On Fri, Aug 13, 2021 at 10:38 PM Gabor Kiss-Vamosi ***@***.***> wrote:
Perhaps this should probably be wrapped in an #if LV_LIB_SJPG_TEST guard,
to prevent this main from being linked into real applications?
E.g. I use Eclipse that automatically collects all the C files. Therefore
there would be 2 main() functions.
You can exclude certain folders from build, but we should make the project
work out of box without any extra configuration.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#26 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMQWRLZOJX7HOY2N67XIRDT4X6MNANCNFSM5B77TKZQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
Looks good, merging. |
Modify the example program, demo_jpg_sjpg, so that it can compile
and link. Doing this will make it easier to detect required changes
when LVGL is changed, as well as function as a simple test program
for this project.