-
Notifications
You must be signed in to change notification settings - Fork 81
Implement more functions #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@C47D @AlixANNERAUD Are you still active? Do you have time to review? |
Great work on the extended type support and the example fixes 👌 Why were the Rust enums replaced with Also, It seems that functions returning |
I could not find and easy way to infer that lv_align_t becomes Align. Maybe a HashMap could be used to manually map types?
Can you give an example for these functions? Every pointer return is skipped because they need an unsafe block. They should be turned into a reference, but I did not know what lifetime to use |
You might want to consider using
From the list of functions you provided (marked in red and prefixed with a |
This PR reworks the LvArgs and LvFunc implementations to handle mutable/immutable primitives, structs, NativeObjects and strings. Also fixes the examples.
List of functions implemented
This breaks the API as what previously took a Rust enum, now takes an i32.
Arrays, void pointers and returned pointers still do not work (those functions are skipped)