-
Notifications
You must be signed in to change notification settings - Fork 193
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update rgb-depth aligned example to be more generic; support alpha sc…
…aling parameter
- Loading branch information
1 parent
e5573f0
commit 0efec25
Showing
2 changed files
with
20 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0efec25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@szabi-luxonis I found 2 issues using latest
develop
commit (d1c103e8
):This one looks better, but still not ideally aligned:
0efec25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Erol444
Would you mind describing the steps to reproduce?
Does latest release work?
0efec25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@szabi-luxonis
Here's gist for repro - essentially the same script as above, just resizing disp frame).
No, it also doesn't work with latest 2.22:
0efec25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Erol444
It works with OV9782.
IMX378 errors out:
Tested with
cc5370b66205d36fae7b772ec6abf0dc6284fb24
, when it was introduced.0efec25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@szabi-luxonis I see, with OV9782 it works ok in my example as well (latest develop), but doesn't work well with imx378 (still works tho).
0efec25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Erol444 that means that RGB alignment itself works, but there are other issues. Either with the
Camera
node and/or with how intrinsics are calculated. Or other issue. For me latest develop doesn't run.I assume configuring ColorCamera at 1920x1080 then undistorting/dewarping w/ ImageManip would work correctly.
0efec25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think latest commit broke it, which added 1352x... resolution to IMX378
0efec25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I tried to use latest code but I got following error on OAK-D:
blended = cv2.addWeighted(frameRgb, rgbWeight, frameDisp, depthWeight, 0)
cv2.error: OpenCV(4.8.1) /Users/xperience/GHA-OpenCV-Python/_work/opencv-python/opencv-python/opencv/modules/core/src/arithm.cpp:650: error: (-209:Sizes of input arguments do not match) The operation is neither 'array op array' (where arrays have the same size and the same number of channels), nor 'array op scalar', nor 'scalar op array' in function 'arithm_op'
Reason is that latestPacket["disp"] is None