refine test asserts+logs; remove Windows requirement

Author: diablodale

tests/src/multiple_devices_test.cpp

@@ -5,7 +5,6 @@
 #include <iostream>
 #include <tuple>
 #include <vector>
-#include <Windows.h>
 
 // Inludes common necessary includes for development using depthai library
 #include "depthai/depthai.hpp"
@@ -115,9 +114,7 @@ TEST_CASE("Multiple devices created and destroyed in parallel") {
         availableDevices = dai::Device::getAllAvailableDevices();
         this_thread::sleep_for(500ms);
     } while(availableDevices.size() <= 1 && steady_clock::now() - t1 <= 3s);
-    //REQUIRE(!availableDevices.empty());
-    if(availableDevices.empty()) throw std::runtime_error("No devices found");
-    if(availableDevices.size() != 3) throw std::runtime_error("All devices not found");
+    REQUIRE(availableDevices.size() >= 2);
 
     // preallocate to avoid reallocation/move
     threads.reserve(availableDevices.size());
@@ -166,11 +163,18 @@ TEST_CASE("Multiple devices created and destroyed in parallel") {
                     device = make_shared<dai::Device>(pipeline, selectedDevice, dai::UsbSpeed::SUPER);
                 }
                 catch(const std::exception& e) {
-                    DebugBreak();
-                    cout << "Failed to create device: " << e.what() << endl;
+                    FAIL_CHECK("Failed to construct Device(" << selectedDevice.mxid << ") " << e.what());
+                    continue;
+                }
+
+                // Call RPC
+                try {
+                    cout << "MXID: " << device->getMxId() << endl;
+                }
+                catch(const std::exception& e) {
+                    FAIL_CHECK("Failed to device(" << selectedDevice.mxid << ")->getMxId() " << e.what());
                     continue;
                 }
-                cout << "MXID: " << device->getMxId() << endl;
 
                 // Create queue callbacks for color and depth
                 if(COLOR_THRESHOLD > 0) {
@@ -203,6 +207,7 @@ TEST_CASE("Multiple devices created and destroyed in parallel") {
                         });
                 } else {
                 }
+                SUCCEED("Device behaved as expected");
             }
         });
     }
@@ -257,9 +262,9 @@ TEST_CASE("Device APIs after Device::close()") {
     device->close();
 
     // Validate Device API behaviors
-    CHECK_THROWS(std::ignore = device->getMxId());
-    CHECK_THROWS(device->setXLinkChunkSize(1024));
+    CHECK_THROWS_AS(std::ignore = device->getMxId(), std::system_error);
+    CHECK_THROWS_AS(device->setXLinkChunkSize(1024), std::system_error);
+    CHECK_THROWS_AS(std::ignore = device->readCalibration(), std::system_error);
     CHECK_NOTHROW(std::ignore = device->getDeviceInfo().name);
     CHECK_NOTHROW(device->setLogOutputLevel(dai::LogLevel::WARN));
-    CHECK_NOTHROW(std::ignore = device->readCalibration());
 }