-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/luxonis dataset integration #50
Conversation
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good generally and I tried it out locally - thanks!
I've left some comments on unimportant details. Maybe the most important being that there is this duplicate ldf_convreter.py
file we likely want to delete.
…com/luxonis/datadreamer into feature/luxonis-dataset-integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but wouldn't it be a good idea to write unit tests for the dataset conversion (to COCO, YOLO and LuxonisDataset format)? @sokovninn
@HonzaCuhel sure, I'll add some unit tests for converters. |
This PR includes: