Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/luxonis dataset integration #50

Merged
merged 24 commits into from
Apr 9, 2024

Conversation

sokovninn
Copy link
Member

This PR includes:

  • Added LuxonisDataset integration
  • Added conversion to COCO and YOLO dataset formats (default is raw)
  • Added script for dataset merging
  • Added unique image names with uuid

@sokovninn sokovninn self-assigned this Apr 7, 2024
Copy link

github-actions bot commented Apr 7, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1230 650 53% 0% 🟢

New Files

File Coverage Status
datadreamer/utils/base_converter.py 96% 🟢
datadreamer/utils/coco_converter.py 95% 🟢
datadreamer/utils/convert_dataset.py 25% 🟢
datadreamer/utils/dataset_utils.py 21% 🟢
datadreamer/utils/luxonis_dataset_converter.py 25% 🟢
datadreamer/utils/merge_raw_datasets.py 0% 🟢
datadreamer/utils/yolo_converter.py 88% 🟢
TOTAL 50% 🟢

Modified Files

File Coverage Status
datadreamer/pipelines/generate_dataset_from_scratch.py 45% 🟢
datadreamer/utils/init.py 100% 🟢
TOTAL 72% 🟢

updated for commit: 896af05 by action🐍

Copy link
Collaborator

@conorsim conorsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good generally and I tried it out locally - thanks!

I've left some comments on unimportant details. Maybe the most important being that there is this duplicate ldf_convreter.py file we likely want to delete.

datadreamer/utils/base_converter.py Outdated Show resolved Hide resolved
datadreamer/utils/ldf_converter.py Outdated Show resolved Hide resolved
datadreamer/utils/dataset_utils.py Outdated Show resolved Hide resolved
datadreamer/utils/ldf_convreter.py Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@HonzaCuhel HonzaCuhel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but wouldn't it be a good idea to write unit tests for the dataset conversion (to COCO, YOLO and LuxonisDataset format)? @sokovninn

@sokovninn
Copy link
Member Author

@HonzaCuhel sure, I'll add some unit tests for converters.

@sokovninn sokovninn merged commit 77811c9 into dev Apr 9, 2024
@sokovninn sokovninn deleted the feature/luxonis-dataset-integration branch September 27, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants