Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined _this reference error when using v-model on select, radio and checkbox. #8

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

janno-p
Copy link
Contributor

@janno-p janno-p commented Apr 3, 2020

Currently select, radio and checkbox controls give undefined _this reference error when using them in jsx block with composition api. Since these element types use onChange event instead of onInput to change the state of the binded target, the patch should also modify _this.$set usages to Vue.set in these handlers also.

@luwanquan luwanquan merged commit 8442edf into luwanquan:master Apr 8, 2020
@luwanquan
Copy link
Owner

Thanks, I missed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants