Skip to content

fix(usage): reseal sidecar OAuth attribution - #372

Closed
luvs01 wants to merge 9 commits into
Devfrom
codex/propose-fix-for-oauth-sidecar-vulnerability
Closed

luvs01 wants to merge 9 commits into
Devfrom
codex/propose-fix-for-oauth-sidecar-vulnerability

Conversation

@luvs01

@luvs01 luvs01 commented Aug 30, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Sidecar OAuth failover updated the request-level label but did not reseal the persisted attempt identity, causing usage to be charged to the account that returned 429 instead of the account that served the retry.

Description

  • Reseal the active usage attempt after a sidecar 429 rotation by calling sealRequestAttemptIdentity(logCtx.activeAttempt, logCtx.provider, rotatedAdapter.name, logCtx.accountLogLabel) in the shared rotateSidecarProviderOn429 path in src/server/responses/core.ts so the attempt-level accountLogLabel matches the request-level label.
  • Add an end-to-end regression in tests/oauth-account-attribution.test.ts that exercises a web-search sidecar failover with two stored OAuth accounts and asserts both the top-level and attempt-level attribution are stamped to the account that actually served the successful retry.
  • Add a streaming Responses fixture completedStream() to support the sidecar streaming retry regression and update the test harness accordingly.

Testing

  • Ran ./node_modules/.bin/bun test tests/oauth-account-attribution.test.ts and the file passed (new sidecar attribution test included).
  • Ran bun run typecheck and bun run privacy:scan and both succeeded.
  • Ran the full bun run test; the modified test passed, but the repository-wide suite surfaced unrelated pre-existing timing/state failures in some Lab and endpoint tests (these failures are not caused by this change).

Codex Task

lidge-jun and others added 9 commits August 25, 2026 10:36
release: promote dev into main for v2.32.1
# Conflicts:
#	package.json
[WRONG BRANCH] merge dev into main for the v2.33.0 release
Promotes the dev integration line onto main. The resulting tree is byte-identical
to origin/dev, including package.json at 2.34.0.

The package.json conflict is resolved to dev's side, NOT to main's stale 2.33.0.
Earlier promotions (lidge-jun#2553, lidge-jun#2507) kept the target's version so the release bump
would land on its own "release: vX.Y.Z" commit. That is no longer legal: this very
delta adds tests/release-version-line.test.ts, which fails when the in-tree version
sits behind the highest release tag. With v2.34.0-preview.20260827 now published,
2.33.0 orders behind it, so a promotion carrying the stale line turns CI red on
every shard that runs the suite.

The consequence for the release step is that scripts/release.ts skips the bump
(release.ts:568, currentVersion === version), so v2.34.0 gets tagged on this merge
commit rather than on a separate release commit. The workflow creates the tag itself
after publishing and validates expected-sha against the checked-out commit, so the
tag still names exactly the audited tree.
[WRONG BRANCH] promote dev onto main for v2.34.0
[WRONG BRANCH] promote dev onto main for v2.35.0
@github-actions

Copy link
Copy Markdown

✅ Deterministic PR hygiene checks passed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-08-30T05:37:10.540012Z e52b834 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added the bug Something isn't working label Aug 30, 2026
@coderabbitai

coderabbitai Bot commented Aug 30, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 565ec613-59b0-4cab-bdee-ccaa54c5f4bb


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 30, 2026 •

Copy link
Copy Markdown

✅ READY

  • all PR quality gates passed.

Hygiene

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot changed the title fix(usage): reseal sidecar OAuth attribution [WRONG BRANCH] fix(usage): reseal sidecar OAuth attribution Aug 30, 2026
@github-actions
github-actions Bot marked this pull request as draft August 30, 2026 05:35
@luvs01 luvs01 changed the title [WRONG BRANCH] fix(usage): reseal sidecar OAuth attribution fix(usage): reseal sidecar OAuth attribution Sep 3, 2026
@luvs01
luvs01 changed the base branch from main to dev September 3, 2026 06:23
@github-actions
github-actions Bot marked this pull request as ready for review September 3, 2026 06:33
@luvs01

luvs01 commented Sep 7, 2026

Copy link
Copy Markdown
Owner Author

상류 dev의 src/server/responses/core.ts가 sealRequestAttemptIdentity(logCtx.activeAttempt, logCtx.provider, rotatedAdapter.name, logCtx.accountLogLabel)를 회전 어댑터 경로에 이미 포함합니다. 상류 커밋 6b508d5a8(lidge-jun#2608)로 반영되어 가치 소멸.

@luvs01 luvs01 closed this Sep 7, 2026
@luvs01
luvs01 deleted the codex/propose-fix-for-oauth-sidecar-vulnerability branch September 20, 2026 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants