Update openssl included or switch to shared ssl from system.

[creationix]

I vote we switch to using the system shared openssl by default so that we get OS updates for free. We don't have the resources to keep our version up to date anymore. We haven't updated since 2016 I believe.

@zhaozg @rphillips what do you think?

[rphillips]

Changing to default makes sense. The windows build might break since it won't have those libraries installed by default (for unit tests). Hopefully we could preserve the windows ssl testing.

/cc @itzg

[creationix]

Yeah, OSX doesn't tend to have system openssl either. Maybe do shared just on linux.

Also @zhaozg what version of lua-openssl will work with modern openssl versions? I get compile errors when switching the build flag to shared. My machine has OpenSSL 1.1.0h 27 Mar 2018

[creationix]

Nevermind, the current version of lua-openssl works. It was the intermittent build failure around hash.h in luajit.

I've got a shiny updated openssl on my archlinix version!

./build/luvi v2.8.0-39-ge30a72e
rex: 8.37 2015-04-28
libuv: 1.22.0
ssl: OpenSSL 1.1.0h  27 Mar 2018, lua-openssl 0.7.1

[zhaozg]

I will make a PR to use lua-openssl 0.7.3, it support openssl 1.0.2/1.1.0/1.1.1.
But openssl Cmake build need large wide update for support 1.1.0.

[zhaozg]

If we want to follow latest openssl, Can me consider using cmake ExternalProject to use openssl office build system?

[rphillips]

ExternalProject looks reasonable.

[zhaozg]

I'll do some try use ExternalProject build openssl, but with a long time.

[squeek502]

The shared openssl by default on Linux has given a few people some problems. Just wanted to log some recent issues brought up in the Discord here in case shared openssl by default is something we want to revisit:

Lautenschlager | Today at 3:42 PM
I am having a glibc problem when I try to host my bot on heroku.

I checked Luvi's repo and the last update was 6 days ago, so that shouldn't be the problem...

There's no way to reproduce it through code. It happens when I try to push my project. I understand it's something about the openssl module...

---

Nameless | Last Sunday at 6:39 PM
i was getting an openssl fatal out of secure-socket NYI, openssl below 1.0.2 not fully support this feature
i might need to compile luvi myself
which would be annoying
[lots of debugging to get them set up with a working self-compiled luvi, lit, luvit]