Lair compiler steps #361
Merged
Lair compiler steps #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriel-barrett
force-pushed
the
lair-compiler-steps
branch
from
02aa068 to
66b6bd4
Compare
wwared
previously approved these changes
Nov 4, 2024
| let block_return_idents = std::mem::take(&mut ctx.return_idents); | ||
| // sanity check |
There was a problem hiding this comment.
nit: Can this sanity check (the assert below this comment) be moved to the check function on BlockE instead?
arthurpaulino
previously approved these changes
Nov 4, 2024
There was a problem hiding this comment.
As the code approaches stability and correctness, we should be striving for more docstrings, especially on more involved functions.
check, expand and compile would be perfect candidates for this. Also, due to the relevance of toplevel.rs, a module docstring would be really good.
src/lair/toplevel.rs
Outdated
Comment on lines
83
to
86
| /// A map from `Var` to its compiled indices and block identifier | ||
| type BindMap = FxHashMap<Var, (List<usize>, usize)>; | ||
| type BindMap = FxHashMap<Var, usize>; | ||
|
|
||
| type LinkMap = FxHashMap<Var, List<usize>>; |
There was a problem hiding this comment.
The docstring for BindMap needs an update
Also, the value type for LinkMap is a bit cryptic. Adding a docstring should help.
gabriel-barrett
dismissed stale reviews from arthurpaulino and wwared
via
30caddb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR substitutes
check_and_linkby a 3-staged approach. First a check, then an expansion (translates complex operations into simple ones), then a compilation into bytecode. This approach, although slightly more inefficient, is much more principled and robustPS: the reason the traces of if statements changed is that the true/false selectors flipped. In the original, it was identifying the true branch as the first branch, now it is the false which is the first. The reason is that the ifs are translated into matches and the true branch is the default case, which appears last