feat: update meta command
#318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement an `update` meta command which can update env variables with arbitrary functions.
arthurpaulino
commented
Oct 1, 2024
| @@ -517,7 +537,7 @@ impl<F: PrimeField32, C1: Chipset<F>, C2: Chipset<F>> MetaCmd<F, C1, C2> { | |||
|
|
|||
| fn validate_binding_var(repl: &Repl<F, C1, C2>, zptr: &ZPtr<F>) -> Result<()> { | |||
| match zptr.tag { | |||
| Tag::Builtin => Ok(()), | |||
| Tag::Builtin | Tag::Coroutine => Ok(()), | |||
There was a problem hiding this comment.
This is a leftover from #311
wwared
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Looks good and useful, thanks!
I will note that this approach will always prepend new values to the env, so as you call !(update ...) the env will grow and grow. Eventually (in the future) we will probably want a better way of updating env maps to remove duplicate keys to minimize the size of envs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement an
updatemeta command which can update env variables with arbitrary functions.