Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the encoding to the HTTPResponseError #708

Merged
merged 5 commits into from
Feb 16, 2024
Merged

Conversation

taik0
Copy link
Contributor

@taik0 taik0 commented Feb 14, 2024

When returning an error from the backend, the content-type matches.
This change only applies when using return_error_code or return_error_details.

… from the backend, the content-type matches. This change only applies when using "return_error_code" or "return_error_details".

Signed-off-by: Daniel Ortiz <dortiz@krakend.io>
@taik0 taik0 requested review from kpacha and dhontecillas February 14, 2024 17:30
Copy link
Member

@kpacha kpacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, fix the failing tests

taik0 and others added 4 commits February 15, 2024 15:25
Signed-off-by: Daniel Ortiz <dortiz@krakend.io>
Signed-off-by: Daniel Ortiz <dortiz@krakend.io>
Resolved issues in transport/http/client/status_test.go with DeepSource Autofix
Signed-off-by: Daniel Ortiz <dortiz@krakend.io>
@taik0 taik0 requested a review from kpacha February 15, 2024 21:51
Copy link
Contributor

@dhontecillas dhontecillas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@kpacha kpacha merged commit a5d1480 into master Feb 16, 2024
5 checks passed
@kpacha kpacha deleted the error_content_type branch February 16, 2024 13:40
Copy link

This pull request was marked as resolved a long time ago and now has been automatically locked as there has not been any recent activity after it. You can still open a new issue and reference this link.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants