Allow GPIO pin #'s > 7. In functions treating GPIO pin types as part of a bitmask, use the type that's used for this purpose and appropriately set for our target to be wide enough to be used. BL602 has 23 GPIOs, so holding them in a bitmask in a uint8_t works poorly. #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In functions treating GPIO pin types as part of a bitmask, use the type that's used for this purpose and appropriately set for our target to be wide enough to be used. BL602 has 23 GPIOs, so holding them in a bitmask in a uint8_t works poorly.
lupyuen
approved these changes
Apr 12, 2022
Owner
|
Thanks for the PR :-) See this: #58 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow GPIO pin #'s > 7. In functions treating GPIO pin types
as part of a bitmask, use the type that's used for this purpose and
appropriately set for our target to be wide enough to be used.
BL602 has 23 GPIOs, so holding them in a bitmask in a uint8_t
works poorly.
Impact
No external impac
Testing
External app controlling GPIO14 on BL602-EVB