Alter when accessor methods are generated. #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -45,10 +45,16 @@ public void visit(int version, int access, String name, String signature, String | |||
|
|
|||
| @Override | |||
| public MethodVisitor visitMethod(int access, String name, String desc, String signature, String[] exceptions) { | |||
| if (isConstructor(name) || isStaticMethod(access)) { | |||
There was a problem hiding this comment.
Having the static methods is the mechanism through which I'm going to implement point 2 on #81. By having a list of the private static methods which are synthetic and looking at invokedynamic's to those methods we can remove the private bit on the static method and skip the accessor.
JakeWharton
force-pushed
the
jw/no-accessor-for-visible-methods
branch
from
d6985da
to
c06dc84
Compare
JakeWharton
changed the title
|
I have updated this to address #89 as well. |
JakeWharton
force-pushed
the
jw/no-accessor-for-visible-methods
branch
from
c06dc84
to
fb6101a
Compare
For owned, non-private methods, omit the accessor since the generated class can access the method directly. For non-owned methods, generate the accessor when the method is protected since the generated class will not have access.
JakeWharton
force-pushed
the
jw/no-accessor-for-visible-methods
branch
from
fb6101a
to
52364bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #81 item 1. This removes 561 methods from our app.
Closes #89.