Created retrolambda maven plugin. see issue #14 #15

davidmoten · 2014-04-17T07:14:39Z

Hi, I created retrolambda-maven-plugin and it is now used in end-to-end-tests. Please review and merge if happy.

Seems to work ok and passes all tests.

I left the dependency plugin and ant plugin combo commented out in end-to-end-tests/pom.xml for reference but I reckon it should be removed once you think the plugin covers the necessary use cases.

I've updated README.md but outstanding is still to put the plugin documentation somewhere. Running mvn clean site in retrolambda-maven-plugin generates the documentation for the plugin in target/site. I put stuff like that in a script like this so I can update it easily. You'd have to setup the orfjackal.github.io repo to facilitate that. GitHub doco tells you how if you haven't got one already.

Cheers
Dave

…nter 1.5,1.6,1.7, 1.8 which is a bit more obvious for most users. Fixed javadoc that only made reference to converting to java 7 bytecode

luontola · 2014-04-18T21:23:23Z

Thanks a lot! I'll review and merge the code in a few days when I have enough time to do it.

Retrolambda Maven plugin

luontola · 2014-05-02T20:40:17Z

Great stuff. I've just released version 1.2.0 which includes this plugin.

luontola · 2014-05-02T21:31:59Z

The plugin had issue #16. Something like to the antrun plugin not being executed in the context of the actual module, and thus not seeing its classpath. It might anyways be better to ask Maven APIs directly for the classpath, because the antrun classpath thing is a hack. I'll have a look at it tomorrow.

davidmoten · 2014-05-02T21:37:36Z

Hmm. I'll have a look too sometime today if kids allow..
Dave
On 3 May 2014 07:32, "Esko Luontola" notifications@github.com wrote:

The plugin had issue #16 #16.
Something like to the antrun plugin not being executed in the context of
the actual module, and thus not seeing its classpath. It might anyways be
better to ask Maven APIs directly for the classpath, because the antrun
classpath thing is a hack. I'll have a look at it tomorrow.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/15#issuecomment-42081270
.

davidmoten · 2014-05-04T07:33:14Z

One way to fix would be to copy deps using the dependency plugin to the
target folder and set the classpath for the Java call using those jars.
Should work fine.
Dave
On 3 May 2014 07:32, "Esko Luontola" notifications@github.com wrote:

The plugin had issue #16 #16.
Something like to the antrun plugin not being executed in the context of
the actual module, and thus not seeing its classpath. It might anyways be
better to ask Maven APIs directly for the classpath, because the antrun
classpath thing is a hack. I'll have a look at it tomorrow.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/15#issuecomment-42081270
.

luontola · 2014-05-04T17:57:12Z

Got it fixed: 919bc69

I've released 1.2.1 which should now work properly.

davidmoten · 2014-05-05T10:32:44Z

very nice fix

@OverRide

public interface MyInterface { default String def() { return "[" + toString() + ", " + "def]"; } default String join(MyInterface other) { return def() + other.def(); } } class C implements MyInterface{} compiles to: public class testpackage.MyClass implements testpackage.MyInterface { public testpackage.MyClass(); Code: 0: aload_0 1: invokespecial luontola#16 // Method java/lang/Object."<init>":()V 4: return public java.lang.String join(testpackage.MyInterface); Code: 0: aload_0 1: aload_1 2: invokestatic luontola#46 // Method testpackage/MyInterfacehelper.join:(Ltestpackage/MyInterface;Ltestpackage/MyInterface;)Ljava/lang/String; 5: areturn public java.lang.String def(); Code: 0: aload_0 1: invokestatic luontola#49 // Method testpackage/MyInterfacehelper.def:(Ltestpackage/MyInterface;)Ljava/lang/String; 4: areturn } Where testpackage.MyInterfacehelper is compiled to public class testpackage.MyInterfacehelper { private testpackage.MyInterfacehelper(); Code: 0: aload_0 1: invokespecial luontola#9 // Method java/lang/Object."<init>":()V 4: return public static java.lang.String def(testpackage.MyInterface); Code: 0: new luontola#13 // class java/lang/StringBuilder 3: dup 4: invokespecial luontola#14 // Method java/lang/StringBuilder."<init>":()V 7: ldc luontola#16 // String [ 9: invokevirtual luontola#20 // Method java/lang/StringBuilder.append:(Ljava/lang/String;)Ljava/lang/StringBuilder; 12: aload_0 13: invokevirtual luontola#24 // Method java/lang/Object.toString:()Ljava/lang/String; 16: invokevirtual luontola#20 // Method java/lang/StringBuilder.append:(Ljava/lang/String;)Ljava/lang/StringBuilder; 19: ldc luontola#26 // String , 21: invokevirtual luontola#20 // Method java/lang/StringBuilder.append:(Ljava/lang/String;)Ljava/lang/StringBuilder; 24: ldc luontola#28 // String def] 26: invokevirtual luontola#20 // Method java/lang/StringBuilder.append:(Ljava/lang/String;)Ljava/lang/StringBuilder; 29: invokevirtual luontola#29 // Method java/lang/StringBuilder.toString:()Ljava/lang/String; 32: areturn public static java.lang.String join(testpackage.MyInterface, testpackage.MyInterface); Code: 0: new luontola#13 // class java/lang/StringBuilder 3: dup 4: invokespecial luontola#14 // Method java/lang/StringBuilder."<init>":()V 7: aload_0 8: invokeinterface luontola#35, 1 // InterfaceMethod testpackage/MyInterface.def:()Ljava/lang/String; 13: invokevirtual luontola#20 // Method java/lang/StringBuilder.append:(Ljava/lang/String;)Ljava/lang/StringBuilder; 16: aload_1 17: invokeinterface luontola#35, 1 // InterfaceMethod testpackage/MyInterface.def:()Ljava/lang/String; 22: invokevirtual luontola#20 // Method java/lang/StringBuilder.append:(Ljava/lang/String;)Ljava/lang/StringBuilder; 25: invokevirtual luontola#29 // Method java/lang/StringBuilder.toString:()Ljava/lang/String; 28: areturn } ============== interface StaticTest { static <T> T staticMethod(T t) { return t; } } compiles to public class testpackage.StaticTesthelper { private testpackage.StaticTesthelper(); Code: 0: aload_0 1: invokespecial luontola#9 // Method java/lang/Object."<init>":()V 4: return public static <T> T staticMethod$static(T); Code: 0: aload_0 1: areturn } ======== Brigde methods are generated properly in example: public interface BridgeParent<T> { T get(); } public interface StringBridges extends BridgeParent<String> { @OverRide default String get() { return "default method"; } default String concrete() { return "concrete"; } } public class testpackage.StringBridgeshelper SourceFile: "testpackage/StringBridges.java" minor version: 0 major version: 50 flags: ACC_PUBLIC, ACC_SUPER Constant pool: luontola#1 = Utf8 testpackage/StringBridgeshelper luontola#2 = Class luontola#1 // testpackage/StringBridgeshelper luontola#3 = Utf8 java/lang/Object luontola#4 = Class luontola#3 // java/lang/Object luontola#5 = Utf8 testpackage/StringBridges.java luontola#6 = Utf8 <init> luontola#7 = Utf8 ()V luontola#8 = NameAndType luontola#6:luontola#7 // "<init>":()V luontola#9 = Methodref luontola#4.luontola#8 // java/lang/Object."<init>":()V luontola#10 = Utf8 get luontola#11 = Utf8 (Ltestpackage/StringBridges;)Ljava/lang/String; luontola#12 = Utf8 default method luontola#13 = String luontola#12 // default method luontola#14 = Utf8 concrete luontola#15 = String luontola#14 // concrete luontola#16 = Utf8 (Ltestpackage/StringBridges;)Ljava/lang/Object; luontola#17 = Utf8 testpackage/StringBridges luontola#18 = Class luontola#17 // testpackage/StringBridges luontola#19 = Utf8 ()Ljava/lang/String; luontola#20 = NameAndType luontola#10:luontola#19 // get:()Ljava/lang/String; luontola#21 = InterfaceMethodref luontola#18.luontola#20 // testpackage/StringBridges.get:()Ljava/lang/String; luontola#22 = Utf8 Code luontola#23 = Utf8 LineNumberTable luontola#24 = Utf8 SourceFile { private testpackage.StringBridgeshelper(); descriptor: ()V flags: ACC_PRIVATE Code: stack=1, locals=1, args_size=1 0: aload_0 1: invokespecial luontola#9 // Method java/lang/Object."<init>":()V 4: return public static java.lang.String get(testpackage.StringBridges); descriptor: (Ltestpackage/StringBridges;)Ljava/lang/String; flags: ACC_PUBLIC, ACC_STATIC Code: stack=1, locals=1, args_size=1 0: ldc luontola#13 // String default method 2: areturn LineNumberTable: line 9: 0 public static java.lang.String concrete(testpackage.StringBridges); descriptor: (Ltestpackage/StringBridges;)Ljava/lang/String; flags: ACC_PUBLIC, ACC_STATIC Code: stack=1, locals=1, args_size=1 0: ldc luontola#15 // String concrete 2: areturn LineNumberTable: line 13: 0 public static java.lang.Object get(testpackage.StringBridges); descriptor: (Ltestpackage/StringBridges;)Ljava/lang/Object; flags: ACC_PUBLIC, ACC_STATIC, ACC_BRIDGE, ACC_SYNTHETIC Code: stack=1, locals=1, args_size=1 0: aload_0 1: invokeinterface luontola#21, 1 // InterfaceMethod testpackage/StringBridges.get:()Ljava/lang/String; 6: areturn LineNumberTable: line 6: 0 }

davidmoten added 18 commits April 16, 2014 22:43

create plugin from archetype

1b7f8ba

use mojo-executor as dep

d957c3c

add eclipse project dot files to .gitignore

101e114

develop plugin

29e14b2

develop maven plugin

ec3c55b

add lambda main source and test source

e2f7ad1

develop maven plugin

be8c3b3

add mojo documentation

92a4a83

remove obsolete test project

f5807de

add to comment

a7588bb

remove unused test dep and update comment

e62479c

remove plugin versions defined in parent

152cc18

update README.md

e4a889a

validate java8home

40985c0

validate java8home

28341bb

replace tabs with spaces

8be3092

replace tabs with spaces

a8b857c

fix constants

b681452

davidmoten mentioned this pull request Apr 17, 2014

Maven Integration #14

Closed

davidmoten added 2 commits April 17, 2014 20:50

change plugin parameter from bytecodeVersion to target so users can e…

b8c4575

…nter 1.5,1.6,1.7, 1.8 which is a bit more obvious for most users. Fixed javadoc that only made reference to converting to java 7 bytecode

tabs to spaces in pom.xml

c32db1a

luontola added a commit that referenced this pull request May 2, 2014

Merge pull request #15 from davidmoten/maven-plugin

5f14a5e

Retrolambda Maven plugin

luontola merged commit 5f14a5e into luontola:master May 2, 2014

davidmoten deleted the maven-plugin branch May 5, 2014 10:30

Arneball mentioned this pull request Aug 11, 2014

Default methods #26

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Created retrolambda maven plugin. see issue #14 #15

Created retrolambda maven plugin. see issue #14 #15

Uh oh!

davidmoten commented Apr 17, 2014

Uh oh!

luontola commented Apr 18, 2014

Uh oh!

luontola commented May 2, 2014

Uh oh!

luontola commented May 2, 2014

Uh oh!

davidmoten commented May 2, 2014

Uh oh!

davidmoten commented May 4, 2014

Uh oh!

luontola commented May 4, 2014

Uh oh!

davidmoten commented May 5, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Created retrolambda maven plugin. see issue #14 #15

Created retrolambda maven plugin. see issue #14 #15

Uh oh!

Conversation

davidmoten commented Apr 17, 2014

Uh oh!

luontola commented Apr 18, 2014

Uh oh!

luontola commented May 2, 2014

Uh oh!

luontola commented May 2, 2014

Uh oh!

davidmoten commented May 2, 2014

Uh oh!

davidmoten commented May 4, 2014

Uh oh!

luontola commented May 4, 2014

Uh oh!

davidmoten commented May 5, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants