Update etcd Docker image to official quay.io/coreos/etcd:v3.6.5#49
Update etcd Docker image to official quay.io/coreos/etcd:v3.6.5#49
Conversation
WalkthroughThe pull request updates two GitHub Actions workflow files (go.yml and sonar.yml) to replace the unavailable Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes The changes are homogeneous and straightforward—consistent image tag replacement and environment variable substitution across two workflow files with minimal logic density. The modifications follow a predictable pattern requiring verification that the new image version and configuration are compatible with existing workflows. Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: dasco144 <10575019+dasco144@users.noreply.github.com>
Co-authored-by: dasco144 <10575019+dasco144@users.noreply.github.com>
Co-authored-by: dasco144 <10575019+dasco144@users.noreply.github.com>
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/go.yml (1)
44-44: Port access syntax differs from sonar.yml, but both should work.In go.yml line 44, the port is accessed via
job.services.etcd.ports[2379](numeric key), whereas sonar.yml line 33 usesjob.services.etcd.ports['2379'](string key). Both syntaxes are valid in GitHub Actions, but consistency across workflows would improve maintainability.If preferred, align both files to use the same port key syntax (either
[2379]or['2379']). The numeric form is slightly more readable. This is optional — both forms function identically.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/go.yml(1 hunks).github/workflows/sonar.yml(2 hunks)
🔇 Additional comments (3)
.github/workflows/sonar.yml (2)
16-16: Official etcd image with pinned version is a solid improvement.Migrating from
bitnami/etcd:latest(no longer freely available) to the maintained officialquay.io/coreos/etcd:v3.6.5with version pinning is the right call for CI reliability and reproducibility. The environment variable changes are correct for the official image:ETCD_LISTEN_CLIENT_URLS: "http://0.0.0.0:2379"enables container accessibility, and the removal of Bitnami-specificALLOW_NONE_AUTHENTICATIONis appropriate.Please verify that
quay.io/coreos/etcd:v3.6.5is still actively maintained and free of known security vulnerabilities. If you need help, I can search the latest release information and CVE advisories.Also applies to: 18-19
40-40: Verify POSIX-compliant trailing newline.The PR notes mention adding a missing trailing newline to sonar.yml for POSIX compliance. Please confirm the file ends with a newline character after line 40.
.github/workflows/go.yml (1)
21-21: Configuration mirrors sonar.yml — good consistency.The image upgrade and environment variables match sonar.yml, which ensures uniform etcd configuration across both CI workflows. The removal of Bitnami-specific authentication and addition of proper listen/advertise URLs are correct for the official etcd image.
Also applies to: 23-24



Problem
The CI workflows were using
bitnami/etcd:latest, which is no longer freely available due to Bitnami/Broadcom's recent policy changes restricting access to their container images. This causes CI failures when trying to pull the image.Solution
This PR migrates both GitHub Actions workflows (
go.ymlandsonar.yml) to use the official etcd Docker image maintained by the etcd project:quay.io/coreos/etcd:v3.6.5Changes
Image Update:
bitnami/etcd:latestquay.io/coreos/etcd:v3.6.5(latest stable version as of October 2025)Environment Variables:
ALLOW_NONE_AUTHENTICATION: "yes"ETCD_LISTEN_CLIENT_URLS: "http://0.0.0.0:2379"- Allows container networking in GitHub ActionsETCD_ADVERTISE_CLIENT_URLS: "http://localhost:2379"- Advertises localhost for proper security postureAdditional Fixes:
sonar.ymlto comply with POSIX standardsWhy This Approach
v3.6.5) instead of:latestensures reproducible buildsTesting
References
Original prompt
Fixes #48
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.
Summary by CodeRabbit