-
Notifications
You must be signed in to change notification settings - Fork 185
update lab task 5f in w01 to clarify type #811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Good point! Is it java.awt.Color or some other Kojo-package with own Color? (I've forgot about this detail as it was a while ago I touched the Kojo internals...) I guess it would be good to state the full package path of the type if you want to take a look in the Kojo code and update your PR? |
I've just checked. It is java.awt.Color. Probably we should import it in the file where other stuff from kojo is imported... |
Yes. Should I still change PR even if we add |
Hmm. We have during the first week not mentioned import but the actual type is
to avoid potential confusion. |
PR is updated. |
I suggest that you change |
Och jag tror det fattas ett "i" före "vecka 4" |
My bad. Should probably be fixed now? |
To generalize
kvadrat
andstapel
so that the pen and fill color can be specified, one needs to know the type of color variables in Kojo. For students to figure the type out, they either have to study the Kojo source code or use Metals' type derivation.I think the type should be specified in this task to minimize confusion.