Skip to content

Conversation

tmablunar
Copy link
Contributor

@tmablunar tmablunar commented Mar 18, 2024

Previous PR removed the role's login if there was no password in the CR but did not actually remove the password itself. This is now removed properly.

@tmablunar tmablunar requested a review from a team March 18, 2024 09:23
Copy link
Contributor

@kjuulh kjuulh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't want the nocreaterole?

Please add a description as well

@tmablunar
Copy link
Contributor Author

You don't want the nocreaterole?

Please add a description as well

The NOCREATEROLE had no effect so just removed it.

@tmablunar tmablunar enabled auto-merge (squash) March 18, 2024 10:27
@tmablunar tmablunar requested a review from kjuulh March 18, 2024 11:43
@tmablunar tmablunar merged commit 88b294a into master Mar 18, 2024
@tmablunar tmablunar deleted the removepw branch March 18, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants