Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: reading default files from .ini file #63

Closed
wants to merge 5 commits into from

Conversation

deining
Copy link
Contributor

@deining deining commented Jun 27, 2020

When reading ini files, the function from_ini is called which takes three parameters. This function was called with only single parameter only, which caused the function to fail.

@Tieske
Copy link
Member

Tieske commented Jul 1, 2020

@deining thx for the PR. Would you mind adding testcases showing the faulty behaviour and the fix?

@deining
Copy link
Contributor Author

deining commented Jul 4, 2020

I added three test cases, as requested. Two of them are directly related to my PR.
The third test case #read_defaults_from_ini_file_group_with_cast is related to #64. It is currently disabled as there is no fix for this issue yet.

Side note: I came across another issue concerning whitespace handling in .ini files: trailing whitespace after the = do not work in groups other than [cli]. Using the config.ini below causes tests to fail:

[cli]
quiet = true
compress = bz2
[database]
host = localhost
port = 5432

@alerque alerque closed this in 684a028 Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants