Use a separate "execute" for running bash commands in containers #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
August 14, 2017 19:18
houndci-bot
reviewed
Aug 15, 2017
|
|
||
| execute.desc 'bash command to run (wrap argument in quotes)' | ||
| execute.arg_name 'BASH_COMMAND' | ||
| execute.flag [:c, :command], type: String, required: true |
There was a problem hiding this comment.
Use %i or %I for an array of symbols.
|
(we already had |
dtboctor
approved these changes
Aug 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided that having the
--commandflag on thebashcommand made the situation more complicated than it should be, especially when introducing the--allswitch, so i separatedexecuteto its own command namespace. I think it's better this way.Also addresses a bug where
Open3would block an interactive session (bug is on master but was not released)