Skip to content

Conversation

@nadav3396
Copy link
Contributor

No description provided.

@nadav3396 nadav3396 changed the title Rd 12691 support aws sdk v 2 java tracer feat: support aws sdk v 2 java tracer (Rd 12691) May 13, 2024
@codecov
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 68.25397% with 100 lines in your changes are missing coverage. Please review.

Project coverage is 81.49%. Comparing base (1fee17a) to head (934d620).
Report is 1 commits behind head on master.

Files Patch % Lines
...tation/impl/AmazonHttpClientV2Instrumentation.java 0.00% 40 Missing ⚠️
src/main/java/io/lumigo/core/SpansContainer.java 88.05% 3 Missing and 5 partials ⚠️
...a/io/lumigo/core/instrumentation/agent/Loader.java 0.00% 8 Missing ⚠️
...ava/io/lumigo/core/parsers/v2/KinesisV2Parser.java 66.66% 5 Missing and 3 partials ⚠️
...in/java/io/lumigo/core/parsers/v2/SnsV2Parser.java 60.00% 6 Missing and 2 partials ⚠️
...in/java/io/lumigo/core/parsers/v2/SqsV2Parser.java 57.89% 6 Missing and 2 partials ⚠️
.../main/java/io/lumigo/core/utils/AwsSdkV2Utils.java 75.00% 3 Missing and 3 partials ⚠️
...va/io/lumigo/core/parsers/v2/DynamoDBV2Parser.java 91.11% 1 Missing and 3 partials ⚠️
...java/io/lumigo/core/parsers/v2/AwsSdkV2Parser.java 62.50% 3 Missing ⚠️
...java/io/lumigo/core/parsers/v1/AwsSdkV1Parser.java 83.33% 0 Missing and 2 partials ⚠️
... and 4 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #65      +/-   ##
============================================
- Coverage     86.82%   81.49%   -5.34%     
- Complexity      314      377      +63     
============================================
  Files            32       42      +10     
  Lines          1230     1524     +294     
  Branches        138      163      +25     
============================================
+ Hits           1068     1242     +174     
- Misses          117      220     +103     
- Partials         45       62      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nadav3396 nadav3396 force-pushed the RD-12691-support-aws-sdk-v-2-java-tracer branch from a157b60 to d698591 Compare May 14, 2024 17:15
@nadav3396 nadav3396 force-pushed the RD-12691-support-aws-sdk-v-2-java-tracer branch from 57c3fe7 to a1ed108 Compare May 15, 2024 09:09
Copy link
Contributor

@moshe-shaham-lumigo moshe-shaham-lumigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nadav3396 nadav3396 merged commit 92252db into master May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants