Skip to content

upgrade yaserde to 0.12 #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
318 changes: 174 additions & 144 deletions Cargo.lock

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ In such cases we don't know in advance what fields must be present in Rust struc

```rust
#[derive(Default, Clone, PartialEq, Debug, YaSerialize, YaDeserialize)]
#[yaserde(prefix = "tns", namespace = "tns: http://example.com")]
#[yaserde(prefix = "tns", namespaces = {"tns" = "http://example.com"})]
pub struct MyType {
#[yaserde(prefix = "tns", rename = "Parameters")]
pub parameters: String,
Expand Down
2 changes: 1 addition & 1 deletion wsdl-parser-cli/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ path = "src/main.rs"
[dependencies]
anyhow = "1"
clap = { version = "4", features = ["derive"] }
roxmltree = { version = "0.19", features = ["std"] }
roxmltree = { version = "0.20", features = ["std"] }
wsdl-parser = { path = "../wsdl-parser" }
xsd-parser = { path = "../xsd-parser" }
2 changes: 1 addition & 1 deletion wsdl-parser/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ license = "MIT OR Apache-2.0"

[dependencies]
Inflector = "0.11"
roxmltree = "0.19"
roxmltree = "0.20"

[dev-dependencies]
syn = { version = "2", features = ["full", "extra-traits"] }
Expand Down
4 changes: 2 additions & 2 deletions wsdl-parser/tests/port_type_to_function/expected.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

#[derive(Default, Clone, PartialEq, Debug, YaSerialize, YaDeserialize)]
#[yaserde(prefix = "tds", namespace = "tds: http://www.onvif.org/ver10/device/wsdl")]
#[yaserde(prefix = "tds", namespaces = {"tds" = "http://www.onvif.org/ver10/device/wsdl"})]
pub struct GetServices {
// Indicates if the service capabilities (untyped) should be included in the
// response.
Expand All @@ -12,7 +12,7 @@ impl Validate for GetServices {}


#[derive(Default, Clone, PartialEq, Debug, YaSerialize, YaDeserialize)]
#[yaserde(prefix = "tds", namespace = "tds: http://www.onvif.org/ver10/device/wsdl")]
#[yaserde(prefix = "tds", namespaces = {"tds" = "http://www.onvif.org/ver10/device/wsdl"})]
pub struct GetServicesResponse {
// Each Service element contains information about one service.
#[yaserde(prefix = "tds", rename = "Service")]
Expand Down
5 changes: 2 additions & 3 deletions xsd-parser/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ license = "MIT OR Apache-2.0"

[dependencies]
Inflector = "0.11"
roxmltree = "0.19"
roxmltree = "0.20"

[dev-dependencies]
num-bigint = "0.4"
Expand All @@ -21,5 +21,4 @@ text-diff = "0.4"
xml-rs = "0.8"
xsd-macro-utils = { path = "../xsd-macro-utils" }
xsd-types = { path = "../xsd-types" }
yaserde = "0.7"
yaserde_derive = "0.7"
yaserde = {version="0.12", features=["derive"]}
4 changes: 2 additions & 2 deletions xsd-parser/src/generator/default.rs
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,13 @@ pub fn default_modify_type(type_name: &str, modifiers: &[TypeModifier]) -> Cow<'
pub fn yaserde_for_attribute(name: &str, indent: &str) -> String {
if let Some(index) = name.find(':') {
format!(
"{}#[yaserde(attribute, prefix = \"{}\", rename = \"{}\")]\n",
"{}#[yaserde(attribute = true, prefix = \"{}\", rename = \"{}\")]\n",
indent,
&name[0..index],
&name[index + 1..]
)
} else {
format!("{}#[yaserde(attribute, rename = \"{}\")]\n", indent, name)
format!("{}#[yaserde(attribute = true, rename = \"{}\")]\n", indent, name)
}
}

Expand Down
5 changes: 4 additions & 1 deletion xsd-parser/src/generator/enum.rs
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,15 @@ pub trait EnumGenerator {
let tns = gen.target_ns.borrow();
match tns.as_ref() {
Some(tn) => match tn.name() {
// needs to put it differently when multiples namespaces are defined.
// namepsaces = {"tns" = "example.com", "tds = "another.example.com"}
Some(name) => format!(
"{derives}#[yaserde(prefix = \"{prefix}\", namespace = \"{prefix}: {uri}\")]\n",
"{derives}#[yaserde(prefix = \"{prefix}\", namespaces = {{\"{prefix}\" = \"{uri}\"}})]\n",
derives = derives,
prefix = name,
uri = tn.uri()
),
// deal with it
None => format!(
"{derives}#[yaserde(namespace = \"{uri}\")]\n",
derives = derives,
Expand Down
3 changes: 2 additions & 1 deletion xsd-parser/src/generator/struct.rs
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,12 @@ pub trait StructGenerator {
match tns.as_ref() {
Some(tn) => match tn.name() {
Some(name) => format!(
"{derives}#[yaserde(prefix = \"{prefix}\", namespace = \"{prefix}: {uri}\")]\n",
"{derives}#[yaserde(prefix = \"{prefix}\", namespaces = {{\"{prefix}\" = \"{uri}\"}})]\n",
derives = derives,
prefix = name,
uri = tn.uri()
),
// todo: deal with it
None => format!(
"{derives}#[yaserde(namespace = \"{uri}\")]\n",
derives = derives,
Expand Down
2 changes: 1 addition & 1 deletion xsd-parser/tests/all/expected.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#[derive(Default, Clone, PartialEq, Debug, YaSerialize, YaDeserialize)]
#[yaserde(prefix = "tns", namespace = "tns: http://example.com")]
#[yaserde(prefix = "tns", namespaces = {"tns" = "http://example.com"})]
pub struct FooType {
#[yaserde(prefix = "tns", rename = "Once")]
pub once: i32,
Expand Down
2 changes: 1 addition & 1 deletion xsd-parser/tests/all/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use super::utils;
fn deserialization_works() {
mod expected {
use xsd_parser::generator::validator::Validate;
use yaserde_derive::{YaDeserialize, YaSerialize};
use yaserde::{YaDeserialize, YaSerialize};

include!("expected.rs");
}
Expand Down
2 changes: 1 addition & 1 deletion xsd-parser/tests/any/expected.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#[derive(Default, Clone, PartialEq, Debug, YaSerialize, YaDeserialize)]
#[yaserde(prefix = "tns", namespace = "tns: http://example.com")]
#[yaserde(prefix = "tns", namespaces = {"tns" = "http://example.com"})]
pub struct FooType {
#[yaserde(prefix = "tns", rename = "Name")]
pub name: String,
Expand Down
2 changes: 1 addition & 1 deletion xsd-parser/tests/any/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use super::utils;
#[test]
fn deserialization_works() {
mod expected {
use yaserde_derive::{YaDeserialize, YaSerialize};
use yaserde::{YaDeserialize, YaSerialize};

include!("expected.rs");
}
Expand Down
6 changes: 3 additions & 3 deletions xsd-parser/tests/choice/expected.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ pub struct BarType(pub String);
pub struct BazType(pub i32);

#[derive(PartialEq, Debug, Clone, YaSerialize, YaDeserialize)]
#[yaserde(prefix = "tns", namespace = "tns: http://example.com")]
#[yaserde(prefix = "tns", namespaces = {"tns" = "http://example.com"})]
pub enum FooTypeChoice {
Bar(BarType),
Baz(BazType),
Expand All @@ -19,8 +19,8 @@ impl Default for FooTypeChoice {
}

#[derive(Default, Clone, PartialEq, Debug, YaSerialize, YaDeserialize)]
#[yaserde(prefix = "tns", namespace = "tns: http://example.com")]
#[yaserde(prefix = "tns", namespaces = {"tns" = "http://example.com"})]
pub struct FooType {
#[yaserde(flatten)]
#[yaserde(flatten = true)]
pub foo_type_choice: FooTypeChoice,
}
2 changes: 1 addition & 1 deletion xsd-parser/tests/choice/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ fn deserialization_works() {
use std::str::FromStr;

use xsd_macro_utils::*;
use yaserde_derive::{YaDeserialize, YaSerialize};
use yaserde::{YaDeserialize, YaSerialize};

include!("expected.rs");
}
Expand Down
2 changes: 1 addition & 1 deletion xsd-parser/tests/complex_type/expected.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#[derive(Default, Clone, PartialEq, Debug, YaSerialize, YaDeserialize)]
#[yaserde(prefix = "tns", namespace = "tns: http://example.com")]
#[yaserde(prefix = "tns", namespaces = {"tns" = "http://example.com"})]
pub struct FooType {
#[yaserde(prefix = "tns", rename = "Min")]
pub min: i32,
Expand Down
2 changes: 1 addition & 1 deletion xsd-parser/tests/complex_type/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use super::utils;
fn deserialization_works() {
mod expected {
use xsd_parser::generator::validator::Validate;
use yaserde_derive::{YaDeserialize, YaSerialize};
use yaserde::{YaDeserialize, YaSerialize};

include!("expected.rs");
}
Expand Down
8 changes: 4 additions & 4 deletions xsd-parser/tests/complex_type_subtypes_clash/expected.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#[derive(Default, Clone, PartialEq, Debug, YaSerialize, YaDeserialize)]
#[yaserde(prefix = "tns", namespace = "tns: http://example.com")]
#[yaserde(prefix = "tns", namespaces = {"tns" = "http://example.com"})]
pub struct FooType {
#[yaserde(prefix = "tns", rename = "Extension")]
pub extension: foo_type::ExtensionType,
Expand All @@ -11,14 +11,14 @@ pub mod foo_type {
use super::*;

#[derive(Default, Clone, PartialEq, Debug, YaSerialize, YaDeserialize)]
#[yaserde(prefix = "tns", namespace = "tns: http://example.com")]
#[yaserde(prefix = "tns", namespaces = {"tns" = "http://example.com"})]
pub struct ExtensionType {}

impl Validate for ExtensionType {}
}

#[derive(Default, Clone, PartialEq, Debug, YaSerialize, YaDeserialize)]
#[yaserde(prefix = "tns", namespace = "tns: http://example.com")]
#[yaserde(prefix = "tns", namespaces = {"tns" = "http://example.com"})]
pub struct BarType {
#[yaserde(prefix = "tns", rename = "Extension")]
pub extension: bar_type::ExtensionType,
Expand All @@ -30,7 +30,7 @@ pub mod bar_type {
use super::*;

#[derive(Default, Clone, PartialEq, Debug, YaSerialize, YaDeserialize)]
#[yaserde(prefix = "tns", namespace = "tns: http://example.com")]
#[yaserde(prefix = "tns", namespaces = {"tns" = "http://example.com"})]
pub struct ExtensionType {}

impl Validate for ExtensionType {}
Expand Down
2 changes: 1 addition & 1 deletion xsd-parser/tests/complex_type_subtypes_clash/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use super::utils;
fn deserialization_works() {
mod expected {
use xsd_parser::generator::validator::Validate;
use yaserde_derive::{YaDeserialize, YaSerialize};
use yaserde::{YaDeserialize, YaSerialize};

include!("expected.rs");
}
Expand Down
2 changes: 1 addition & 1 deletion xsd-parser/tests/enumeration/expected.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#[derive(PartialEq, Debug, Clone, YaSerialize, YaDeserialize)]
#[yaserde(prefix = "tns", namespace = "tns: http://example.com")]
#[yaserde(prefix = "tns", namespaces = {"tns" = "http://example.com"})]
pub enum FooType {
#[yaserde(rename = "OFF")]
Off,
Expand Down
2 changes: 1 addition & 1 deletion xsd-parser/tests/enumeration/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ fn deserialization_works() {

use xsd_macro_utils::*;
use xsd_parser::generator::validator::Validate;
use yaserde_derive::{YaDeserialize, YaSerialize};
use yaserde::{YaDeserialize, YaSerialize};

include!("expected.rs");
}
Expand Down
4 changes: 2 additions & 2 deletions xsd-parser/tests/extension_base/expected.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#[derive(Default, Clone, PartialEq, Debug, YaSerialize, YaDeserialize)]
#[yaserde(prefix = "tns", namespace = "tns: http://example.com")]
#[yaserde(prefix = "tns", namespaces = {"tns" = "http://example.com"})]
pub struct BarType {
#[yaserde(prefix = "tns", rename = "b")]
pub b: i32,
Expand All @@ -11,7 +11,7 @@ pub struct BarType {
impl Validate for BarType {}

#[derive(Default, Clone, PartialEq, Debug, YaSerialize, YaDeserialize)]
#[yaserde(prefix = "tns", namespace = "tns: http://example.com")]
#[yaserde(prefix = "tns", namespaces = {"tns" = "http://example.com"})]
pub struct FooType {
#[yaserde(prefix = "tns", rename = "a")]
pub a: f64,
Expand Down
2 changes: 1 addition & 1 deletion xsd-parser/tests/extension_base/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use super::utils;
fn deserialization_works() {
mod expected {
use xsd_parser::generator::validator::Validate;
use yaserde_derive::{YaDeserialize, YaSerialize};
use yaserde::{YaDeserialize, YaSerialize};

include!("expected.rs");
}
Expand Down
6 changes: 3 additions & 3 deletions xsd-parser/tests/extension_base_multilayer/expected.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#[derive(Default, Clone, PartialEq, Debug, YaSerialize, YaDeserialize)]
#[yaserde(prefix = "tns", namespace = "tns: http://example.com")]
#[yaserde(prefix = "tns", namespaces = {"tns" = "http://example.com"})]
pub struct BarType {
#[yaserde(prefix = "tns", rename = "aa")]
pub aa: i32,
Expand All @@ -11,7 +11,7 @@ pub struct BarType {
impl Validate for BarType {}

#[derive(Default, Clone, PartialEq, Debug, YaSerialize, YaDeserialize)]
#[yaserde(prefix = "tns", namespace = "tns: http://example.com")]
#[yaserde(prefix = "tns", namespaces = {"tns" = "http://example.com"})]
pub struct FooType {
#[yaserde(prefix = "tns", rename = "Messages")]
pub messages: foo_type::MessagesType,
Expand All @@ -23,7 +23,7 @@ pub mod foo_type {
use super::*;

#[derive(Default, Clone, PartialEq, Debug, YaSerialize, YaDeserialize)]
#[yaserde(prefix = "tns", namespace = "tns: http://example.com")]
#[yaserde(prefix = "tns", namespaces = {"tns" = "http://example.com"})]
pub struct MessagesType {
#[yaserde(prefix = "tns", rename = "a")]
pub a: String,
Expand Down
2 changes: 1 addition & 1 deletion xsd-parser/tests/extension_base_multilayer/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use super::utils;
fn deserialization_works() {
mod expected {
use xsd_parser::generator::validator::Validate;
use yaserde_derive::{YaDeserialize, YaSerialize};
use yaserde::{YaDeserialize, YaSerialize};

include!("expected.rs");
}
Expand Down
3 changes: 1 addition & 2 deletions xsd-parser/tests/extension_base_two_files/expected.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
#[derive(Default, Clone, PartialEq, Debug, YaSerialize, YaDeserialize)]
#[yaserde(
prefix = "tns",
namespace = "tns: http://example.com",
namespace = "tns2: http://other.example.com"
namespaces = {"tns" = "http://example.com", "tns2" = "http://other.example.com"},
)]
pub struct FooType {
#[yaserde(prefix = "tns", rename = "a")]
Expand Down
2 changes: 1 addition & 1 deletion xsd-parser/tests/extension_base_two_files/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use super::utils;
#[test]
fn deserialization_works() {
mod expected {
use yaserde_derive::{YaDeserialize, YaSerialize};
use yaserde::{YaDeserialize, YaSerialize};
include!("expected.rs");
}

Expand Down
4 changes: 2 additions & 2 deletions xsd-parser/tests/ref_to_attribute/expected.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ pub struct Id(pub String);

impl Validate for Id {}
#[derive(Default, Clone, PartialEq, Debug, YaSerialize, YaDeserialize)]
#[yaserde(prefix = "tns", namespace = "tns: http://example.com")]
#[yaserde(prefix = "tns", namespaces = {"tns" = "http://example.com"})]
pub struct FooType {
#[yaserde(attribute, prefix = "tns", rename = "id")]
#[yaserde(attribute = true, prefix = "tns", rename = "id")]
pub id: Option<Id>,
}

Expand Down
2 changes: 1 addition & 1 deletion xsd-parser/tests/ref_to_attribute/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ fn deserialization_works() {

use xsd_macro_utils::*;
use xsd_parser::generator::validator::Validate;
use yaserde_derive::{YaDeserialize, YaSerialize};
use yaserde::{YaDeserialize, YaSerialize};

include!("expected.rs");
}
Expand Down
2 changes: 1 addition & 1 deletion xsd-parser/tests/rename_only_where_needed/expected.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#[derive(Default, Clone, PartialEq, Debug, YaSerialize, YaDeserialize)]
#[yaserde(prefix = "tns", namespace = "tns: http://example.com")]
#[yaserde(prefix = "tns", namespaces = {"tns" = "http://example.com"})]
pub struct FooType {
#[yaserde(prefix = "tns")]
pub min: i32,
Expand Down
2 changes: 1 addition & 1 deletion xsd-parser/tests/rename_only_where_needed/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use super::utils;
#[test]
fn deserialization_works() {
mod expected {
use yaserde_derive::{YaDeserialize, YaSerialize};
use yaserde::{YaDeserialize, YaSerialize};
include!("expected.rs");
}

Expand Down
8 changes: 4 additions & 4 deletions xsd-parser/tests/restriction_any_type/expected.rs
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
// pub type AppSequence = AppSequenceType;
#[derive(Default, Clone, PartialEq, Debug, YaSerialize, YaDeserialize)]
#[yaserde(prefix = "tns", namespace = "tns: http://schemas.xmlsoap.org/ws/2005/04/discovery")]
#[yaserde(prefix = "tns", namespaces = {"tns" = "http://schemas.xmlsoap.org/ws/2005/04/discovery"})]
pub struct AppSequenceType {
#[yaserde(attribute, rename = "InstanceId")]
#[yaserde(attribute = true, rename = "InstanceId")]
pub instance_id: u32,

#[yaserde(attribute, rename = "SequenceId")]
#[yaserde(attribute = true, rename = "SequenceId")]
pub sequence_id: Option<String>,

#[yaserde(attribute, rename = "MessageNumber")]
#[yaserde(attribute = true, rename = "MessageNumber")]
pub message_number: u32,
}

Expand Down
2 changes: 1 addition & 1 deletion xsd-parser/tests/restriction_any_type/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use super::utils;
fn deserialization_works() {
mod expected {
use xsd_parser::generator::validator::Validate;
use yaserde_derive::{YaDeserialize, YaSerialize};
use yaserde::{YaDeserialize, YaSerialize};

include!("expected.rs");
}
Expand Down
2 changes: 1 addition & 1 deletion xsd-parser/tests/tuple_with_vec/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ fn deserialization_works() {
assert_eq!(de, expected::FooType(vec![1, 2, 3]));

assert_eq!(
r#"<?xml version="1.0" encoding="utf-8"?><FooType>1 2 3</FooType>"#,
r#"<?xml version="1.0" encoding="UTF-8"?><FooType>1 2 3</FooType>"#,
yaserde::ser::to_string(&de).unwrap()
);
}
Expand Down
Loading