Refactor Event System #93
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AI Summary
This pull request includes several changes to the event handling system and some minor improvements in the bot's task management. The most important changes involve the removal of the
SubscriptionandReceiverSubscriptionstructs, modifications to theEventstruct, and updates to theArcObservableandEventRepeaterimplementations.Event Handling System:
src/event.rs: Removed thesubscriptionmodule and its usage across the codebase.src/event/event.rs: Updated thesubscribe_channel,subscribe_async_closure, andsubscribe_closuremethods to returnUuidinstead ofSubscription. Modifiedunsubscribemethod to useUuiddirectly. [1] [2] [3] [4] [5] [6]src/event/subscription.rs: Removed theSubscriptionandReceiverSubscriptionstructs entirely.ArcObservable Improvements:
src/event/arc_observable.rs: Simplified thegetmethod and added anAsRefimplementation forEvent<Mutex<T>>. [1] [2]EventRepeater Updates:
src/event/event_repeater.rs: Adjusted to work withUuidinstead ofSubscriptionfor managing subscriptions. [1] [2] [3]Bot Task Management:
src/bot.rs: Added task ID handling and improved the subscription mechanism for status change events. [1] [2]