Configurable adapter factory #306
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: mbolli <722725+mbolli@users.noreply.github.com>
Co-authored-by: mbolli <722725+mbolli@users.noreply.github.com>
Co-authored-by: mbolli <722725+mbolli@users.noreply.github.com>
Co-authored-by: mbolli <722725+mbolli@users.noreply.github.com>
Add adapter_factory_class config option for custom adapters
lulco
reviewed
Jan 12, 2026
| { | ||
| public static function instance(EnvironmentConfig $config): AdapterInterface | ||
| { | ||
| throw new \RuntimeException('Mock adapter factory should not be instantiated in tests'); |
Owner
|
LGTM, need to test for a while on some projects |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for custom database adapter factories, allowing users to specify their own adapter factory class in the configuration. This brings greater flexibility for integrating custom database adapters. The changes include updates to the configuration handling, command usage, and related documentation, as well as tests to ensure correct behavior.
Configuration and Extensibility:
adapter_factory_classconfiguration option, allowing users to specify a fully qualified class name for a custom adapter factory. The class must implementPhoenix\Database\Adapter\AdapterFactoryInterface, and defaults toPhoenix\Database\Adapter\AdapterFactory.AdapterFactoryInterfaceinterface and updated the existingAdapterFactoryto implement it, enabling custom adapter factories.Command and Internal Usage:
AdapterFactory.Dependency and Compatibility:
composer.jsonto allow both Symfony Console v7.4 and v8.0, increasing compatibility.Testing:
adapter_factory_classconfiguration, including validation of default, invalid, and custom values. Introduced aMockAdapterFactoryfor testing purposes.