docs: Modernize token metadata guides #1320
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metadata-preparation.md: - Fix JSON syntax error (missing comma between image objects) - Add verification to icon (was missing) - Update encodeData() to array format edit-token-metadata.md: - Add ethers.js + web3.js + Hardhat tabs (was Hardhat-only) - Use UP Browser Extension for ethers/web3 tabs - Fix missing LSP7Artifact import - Fix ethers.Contract instantiation (was missing 'new') - Add setDataBatch() example (was mentioned but not shown) - Link to correct contract docs - Update description meta tag
Contributor
Deployed with Cloudflare Pages ☁️ 🚀 🆗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the Metadata Preparation and Set LSP7 Token Metadata guides to match current patterns.
Changes
metadata-preparation.md
imagesarrayiconfield was missing averificationobject (all other image types had it)encodeData()to array format (current erc725.js API)edit-token-metadata.md
window.luksoprovider)ethers.Contractinstantiation — was missingnewkeywordLSP7Artifactimport — was referenced but never importedsetDataBatch()example — was mentioned in text but never shownRelated to review feedback on #1318.