Skip to content

Fix text color and alignment not updating if changed through their modifiers #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix text color and alignment not updating if changed through their modifiers #12

wants to merge 2 commits into from

Conversation

ipodishima
Copy link

Hi

textColor and textAlignment when updated after the view was initialized, were not given to the textField through updateUIView.
This PR fixes that.

lukeredpath
lukeredpath requested changes Oct 7, 2022
View reviewed changes
Copy link
Owner

@lukeredpath lukeredpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, and the typos, but there's no need to change British spellings to US. I am British. ;)

@ipodishima
Copy link
Author

Ohhhhhh sorry for the typos :p

TBH I just updated what Xcode was highlighting, I'm french myself so switching from US / UK words without knowing which one belongs to whom ahah

@mergesort mergesort mentioned this pull request Aug 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeredpath lukeredpath lukeredpath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ipodishima @lukeredpath