Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nit: Replace references to "bash" #10

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Nit: Replace references to "bash" #10

merged 1 commit into from
Oct 13, 2021

Conversation

niieani
Copy link
Contributor

@niieani niieani commented Oct 13, 2021

Small nit: the concept of shebang has nothing to do with bash. In fact, by adding the shebang pointing to tsm, we're telling unix subsystems to NOT run the script using the current shell (like bash), but using tsm as the interpreter instead.

@lukeed
Copy link
Owner

lukeed commented Oct 13, 2021

Right, but phrasing was hard. Polled a few and "bash script" was more immediately obvious to people what it meant, even though technically incorrect. I think this replacement should be equally clear. Thanks 👍

@lukeed lukeed merged commit 73b8c77 into lukeed:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants