Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for NVM_SILENT environment variable #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for NVM_SILENT environment variable #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,17 @@ export NVM_AUTO_USE=true
antigen bundle lukechilds/zsh-nvm
```

### Silent switching

If you use `Auto use` feature of this plugin with a theme that supports node version printing, you may want to disable some messages that nvm prints when it switches between versions. You can disable it by exporting the `NVM_SILENT` environment variable and setting it to `true`.

For example, if you are using antigen, you would put the following in your `.zshrc`:

```shell
export NVM_SILENT=true
antigen bundle lukechilds/zsh-nvm
```

## Installation

### Using [Antigen](https://github.com/zsh-users/antigen)
Expand Down
16 changes: 12 additions & 4 deletions zsh-nvm.plugin.zsh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,11 +174,19 @@ _zsh_nvm_auto_use() {
if [[ "$nvmrc_node_version" = "N/A" ]]; then
nvm install && export NVM_AUTO_USE_ACTIVE=true
elif [[ "$nvmrc_node_version" != "$node_version" ]]; then
nvm use && export NVM_AUTO_USE_ACTIVE=true
if [[ "$NVM_SILENT" = true ]]; then
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an assignment instead of a condition.

nvm use --silent && export NVM_AUTO_USE_ACTIVE=true
else
nvm use && export NVM_AUTO_USE_ACTIVE=true
fi
fi
elif [[ "$node_version" != "$(nvm version default)" ]] && [[ "$NVM_AUTO_USE_ACTIVE" = true ]]; then
echo "Reverting to nvm default version"
nvm use default
if [[ "$NVM_SILENT" = true ]]; then
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is too

nvm use default --silent
else
echo "Reverting to nvm default version"
nvm use default
fi
fi
}

Expand Down Expand Up @@ -216,7 +224,7 @@ if [[ "$ZSH_NVM_NO_LOAD" != true ]]; then

# Enable completion
[[ "$NVM_COMPLETION" == true ]] && _zsh_nvm_completion

# Auto use nvm on chpwd
[[ "$NVM_AUTO_USE" == true ]] && add-zsh-hook chpwd _zsh_nvm_auto_use && _zsh_nvm_auto_use
fi
Expand Down