upgrade to PyFCM 2.1.0, use google oauth lib to load credentials #7

J-Priebe · 2024-08-20T17:14:41Z

No description provided.

fcm_devices/fcm.py

J-Priebe · 2024-08-21T16:20:06Z

README.md


 device = Device.objects.get(user_id=123)  # get the device for the user you want to message

-# To multiple devices


note that the new API no longer supports multicasting

lukeburden

Thanks @J-Priebe! Appreciate the PR.

A couple of questions, but generally looks good and I'll author a release soon.

fcm_devices/settings.py

lukeburden · 2024-08-25T22:13:19Z

testproj/testproj/settings.py

 STATIC_URL = "/static/"

-DEVICES_FCM_API_KEY = "oopwhoopdoop"
+DEVICES_GOOGLE_SERVICE_ACCOUNT_INFO = {"foo": "bar"}


Remind me why it's DEVICES prefix here but FCM_DEVICES in the test settings?

No idea ;) old code, or perhaps you specify the prefix at a config level somewhere, and this is just ascertaining you can use different prefixes?

…is where we were testing anyway

lukeburden

Thanks @J-Priebe, appreciate your PR.

A couple of comments inline - but basically this looks great and I'm just hoping we can avoid the super tight dependency versioning you've added, as this can end up causing a lot of friction.

Also I saw at least one of your PRs to PyFCM has been merged now, so perhaps there are further adjustments?

Cheers!

lukeburden · 2024-08-31T20:51:34Z

setup.py

-    # and 1.5.x currently look good.
-    # https://github.com/olucurious/PyFCM/issues/285
-    "pyfcm>=1.4,<1.6",
+    "pyfcm==2.0.6",


Can we loosen the pyfcm dependency?

Perhaps. I'm a bit wary of the author's versioning. He isn't very active and there doesn't seem to be much oversight on PRs. I haven't looked too deeply at the test suites for this repo, and I've never released a library before so I'm not too certain of best practices here, but I think we'd want to ensure the method signatures and handling of mocked responses are consistent across a wide range of versions.

I have another PR in my head that I'd like to submit to PyFCM around optional arguments - maybe we can circle back to this in a couple weeks when I've got that merged in and there's a new PyFCM version released?

Update: My second PR was merged and released in 2.0.7. However he hasn't authored any release notes since 2.0.1 when the breaking google API changes were addressed. I think we're betting off erring on the side of caution and pinning 2.0.7.

EDIT: NVM, my changes aren't in yet, we have to wait for 2.0.8 😑

lukeburden · 2024-08-31T20:52:11Z

setup.py

-    "pyfcm>=1.4,<1.6",
+    "pyfcm==2.0.6",
    "django-konst>=2,<3",
+    "google-auth==2.22.0", # for loading credentials.


pyfcm has this as a dependency, so we can rely on that

I don't think it's good practice to rely on a package dependency to do things outside that package. Since we're doing the loading of google credentials outside PyFCM, django-fcm-devices should have its own explicit dependency (which can be satisfied by PyFCM)

lukeburden · 2024-08-31T20:53:02Z

tox.ini

    djangorestframework>=3.10
    django-konst>=2,<3
-    pyfcm==1.5.1
+    pyfcm==2.0.6


Depending on your response to my earlier comments on reqs, may need adjustment.

…e breaking changes

J-Priebe · 2024-12-30T20:04:09Z

Gah, I was mistaken and my changes to PyFCM haven't been merged in yet.. we need to wait for 2.0.8. I've done some general cleanup and I think this looks pretty good once 2.0.8 is actually available.

J-Priebe · 2024-12-30T20:08:17Z

tox.ini

+env_list =
    checkqa
-    py{36,37,38,39}-dj{22,30,31,master}
+    py{38,39,310,311,312}-dj{22,30,31,32}


I've updated tox to reflect that 3.6 - 3.8 are past end of life (3.8 recently, so I've left it in as pyenv still supports it, for now)

django master is now on 5.x, and actually this is broken by 4.x + due to changes in Signal args, so I removed it as well. 4+ is already disallowed in dependencies

My sense is py3.8 is so broadly used, even though it's EOL it probably makes sense to support it for now.

We can add support for further Python and Django versions in a separate PR, kinda similar to what I've done over here for django-konst. I haven't closely looked, but my guess is there'll be backward compatible changes required so will justify a major release.

lukeburden · 2025-01-03T03:06:26Z

Gah, I was mistaken and my changes to PyFCM haven't been merged in yet.. we need to wait for 2.0.8. I've done some general cleanup and I think this looks pretty good once 2.0.8 is actually available.

No rush on my end. Any idea if/when the maintainer will get to it?

J-Priebe added 5 commits August 20, 2024 13:14

upgrade to PyFCM 2.0.1, use google oauth lib to load credentials

9c6c077

version

f2d5136

missing Credentials

e73a56e

readme

aa80961

missing positional args

7a3d9f3

J-Priebe commented Aug 20, 2024

View reviewed changes

fcm_devices/fcm.py Outdated Show resolved Hide resolved

add scope to credentials

7a62870

J-Priebe commented Aug 21, 2024

View reviewed changes

cleanup

6800f86

lukeburden reviewed Aug 25, 2024

View reviewed changes

J-Priebe added 5 commits August 26, 2024 16:12

update error handling in accordance with PyFCM and Google API responses

05ff7d1

pin 2.0.1

c535b85

missing =

3794017

google-auth lib was downgraded in 2.0.4, so just pin on 2.0.6, which …

03077cb

…is where we were testing anyway

docstring

2ed6138

J-Priebe changed the title ~~upgrade to PyFCM 2.0.1, use google oauth lib to load credentials~~ upgrade to PyFCM 2.0.6, use google oauth lib to load credentials Aug 26, 2024

J-Priebe added 3 commits August 27, 2024 10:28

error handling

a7f857b

pull project_id from credentials instead of redundant app setting

e25fb35

more docco updates

ad6dd82

lukeburden reviewed Aug 31, 2024

View reviewed changes

update renamed args

6ba7515

J-Priebe changed the title ~~upgrade to PyFCM 2.0.6, use google oauth lib to load credentials~~ upgrade to PyFCM 2.0.7, use google oauth lib to load credentials Dec 30, 2024

J-Priebe added 3 commits December 30, 2024 12:27

factor in changes in 2.0.7

2f031e4

lint; update tox.ini for modern python installs

17b7875

fix tox versions and remove implied support for django 4+ as there ar…

d317511

…e breaking changes

J-Priebe changed the title ~~upgrade to PyFCM 2.0.7, use google oauth lib to load credentials~~ upgrade to PyFCM 2.0.8, use google oauth lib to load credentials Dec 30, 2024

J-Priebe commented Dec 30, 2024

View reviewed changes

pyfcm 2.0.8 (not yet released)

41f2650

J-Priebe changed the title ~~upgrade to PyFCM 2.0.8, use google oauth lib to load credentials~~ upgrade to PyFCM 2.1.0, use google oauth lib to load credentials Oct 6, 2025

J-Priebe added 2 commits October 6, 2025 14:22

more tests, more tox

2fd6a9c

lint

044d63b


		device = Device.objects.get(user_id=123) # get the device for the user you want to message

		# To multiple devices

upgrade to PyFCM 2.1.0, use google oauth lib to load credentials #7

Are you sure you want to change the base?

upgrade to PyFCM 2.1.0, use google oauth lib to load credentials #7

Uh oh!

Conversation

J-Priebe commented Aug 20, 2024

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lukeburden left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lukeburden left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

J-Priebe Dec 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

J-Priebe Dec 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

J-Priebe commented Dec 30, 2024

Uh oh!

J-Priebe Dec 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lukeburden commented Jan 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

J-Priebe Dec 30, 2024 •

edited

Loading

J-Priebe Dec 30, 2024 •

edited

Loading

J-Priebe Dec 30, 2024 •

edited

Loading