Skip to content

Conversation

@filipef101
Copy link
Contributor

There was no lib update on commit 2118b4e

This also fixes a typescript error I found when compiling it and while at it update types to latest RN

@filipef101
Copy link
Contributor Author

@lukebrandonfarrell pinging you as I cannot assign reviewer, hope to get this merged soon to avoid using a patch 👍

@filipef101
Copy link
Contributor Author

@dorukcan Just a friendly reminder to use semantic commits otherwise CI won't trigger releases

@dorukcan
Copy link
Contributor

dorukcan commented Oct 27, 2022

@filipef101 oh i missed that, thanks

@filipef101
Copy link
Contributor Author

Not sure if I should commit the lib changes, or if that is done on CI? I'm assuming it's not part of CI

@lukebrandonfarrell
Copy link
Owner

Looks good to me @filipef101 :)

@lukebrandonfarrell lukebrandonfarrell merged commit 326655d into lukebrandonfarrell:master Nov 2, 2022
@github-actions
Copy link

github-actions bot commented Nov 2, 2022

🎉 This PR is included in version 4.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lukebrandonfarrell
Copy link
Owner

@all-contributors add @filipef101 for code

@allcontributors
Copy link
Contributor

@lukebrandonfarrell

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token ] in JSON at position 927

@lukebrandonfarrell
Copy link
Owner

@all-contributors add @filipef101 for code

@allcontributors
Copy link
Contributor

@lukebrandonfarrell

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token ] in JSON at position 927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants