Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CVE-2021-23369 finding for modules using CLI [#1130] #1131

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

ra100
Copy link
Contributor

@ra100 ra100 commented Nov 9, 2021

handlebars@4.7.7 is already in the yarn.lock, but when TSOA is imported,
yarn audit finds this issue, based on version in package.json version
GHSA-f2jv-r9rf-7988

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • N/A - Have you written unit tests?
  • N/A - Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • - This PR is associated with an existing issue? Projects importing TSOA report Critical CVE finding #1130

Closing issues

closes #1130

If this is a new feature submission:

  • Has the issue had a maintainer respond to the issue and clarify that the feature is something that aligns with the goals and philosophy of the project?

Potential Problems With The Approach

None

Test plan

N/A

@ra100
Copy link
Contributor Author

ra100 commented Nov 9, 2021

If this doesn't make sense, feel free to just decline :)
And I'll use "resolutions" on package.json, in our project.

@mrl5
Copy link
Contributor

mrl5 commented Nov 9, 2021

@ra100 I think you should consider committing also yarn.lock

in case you need more info:

`handlebars@4.7.7` is already in the yarn.lock, but when TSOA is imported,
yarn audit finds this issue, based on version in package.json version
GHSA-f2jv-r9rf-7988
@ra100 ra100 force-pushed the fix-CVE-2021-23369 branch from 16c21c5 to 3dd7b43 Compare November 10, 2021 08:54
@ra100
Copy link
Contributor Author

ra100 commented Nov 10, 2021

@mrl5 right, my bad, of course, done

@WoH WoH merged commit 8160359 into lukeautry:master Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Projects importing TSOA report Critical CVE finding
3 participants