Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why php-feed-writer is a "project" composer type #5

Open
pH-7 opened this issue Dec 22, 2021 · 8 comments
Open

Why php-feed-writer is a "project" composer type #5

pH-7 opened this issue Dec 22, 2021 · 8 comments

Comments

@pH-7
Copy link

pH-7 commented Dec 22, 2021

Hello Lukas!

I believe this library should be a "library" type in your composer.json file, and not a "project type. Because of this wrong type, I get the following error on composer v2 since it is not a library.

Could not find a matching version of package lukaswhitephp-feed-writer.

Finally, on packages.org, it shows composer create-project as you mentioned "type": "project" in your composer.json file.

Screenshot 2021-12-22 at 20 32 07

As soon as you change from "type": "project", to "type": "library",, packages.org will display composer require on your library packagist page.

pH-7 added a commit to pH-7/php-feed-writer that referenced this issue Dec 22, 2021
@pH-7
Copy link
Author

pH-7 commented Dec 22, 2021

FYI @lukaswhite, I created a PR to do so. #6

@pH-7
Copy link
Author

pH-7 commented Feb 7, 2022

Let me know when you can check out the PR, @lukaswhite 😃

@pH-7
Copy link
Author

pH-7 commented Apr 23, 2022

Let me know when you can check out the PR, @lukaswhite 😃

👋 @lukaswhite 🙂

@sudofox
Copy link

sudofox commented Dec 6, 2022

Is this project still maintained? I was looking at it as something I might be able to use

@pH-7
Copy link
Author

pH-7 commented Dec 8, 2022

@sudofox Well, it doesn't look to be maintained anymore... as my PR and this issue didn't get any replies from its author @lukaswhite, and the last update was made two years ago.

@pH-7
Copy link
Author

pH-7 commented Dec 8, 2022

@sudofox You could still create a fork from this one though, and build from there...

@lukaswhite
Copy link
Owner

Yes, it's still maintained. I hadn't seen this issue, it's been a tumultuous couple of years. I've been using it for a while with no problems, so there hasn't seemed much need to do anything on it - though a PHP8.1 version might be a good idea.

@pH-7 I'll get that PR merged this week.
@sudofox Any specific issues, or just checking?

@sudofox
Copy link

sudofox commented Dec 8, 2022

@lukaswhite I was just checking -- been thinking about adding RSS/Atom feed functionality to a small website of mine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants