Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure sortenter event is fired when a dragged element enters container the first time #492

Closed

Conversation

christophe-g
Copy link
Contributor

@christophe-g christophe-g commented Mar 1, 2019

Motivation:

  • Be able to listen to sortenter event - useful when dragging to a different list and wish to update placeholder content.
  • Make sure we have a way to trace back the original target in sortstart and sortenter event. When sortable is used with copy = true, the dragged item is a deep-copy of the original target. This prevents accessing the real original target. This is a problem in some cases (like in polymer dom-repeat component) where only the original target holds some linked properties.

@coveralls
Copy link

coveralls commented Mar 1, 2019

Coverage Status

Coverage remained the same at 8.0% when pulling 88ad41f on christophe-g:dispatch-sortenter into 872e0ce on lukasoppermann:master.

@christophe-g
Copy link
Contributor Author

Sorry for the number of commits on this one. Had to reconcile history tree between my branch and yours.

@christophe-g
Copy link
Contributor Author

@lukasoppermann - hey
If you agree with the proposed changes, I'll re-push with a clean commit history (just re-branch from your master and replay the changes).

@christophe-g christophe-g deleted the dispatch-sortenter branch March 2, 2019 11:19
@christophe-g christophe-g mentioned this pull request Mar 2, 2019
@christophe-g
Copy link
Contributor Author

christophe-g commented Mar 2, 2019

Closing as replaced by #494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants