-
-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make sure sortenter event is fired when a dragged element enters container the first time #492
Closed
christophe-g
wants to merge
14
commits into
lukasoppermann:master
from
christophe-g:dispatch-sortenter
Closed
make sure sortenter event is fired when a dragged element enters container the first time #492
christophe-g
wants to merge
14
commits into
lukasoppermann:master
from
christophe-g:dispatch-sortenter
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ainer the first time
christophe-g
force-pushed
the
dispatch-sortenter
branch
from
March 1, 2019 22:09
f2e4fc8
to
e1555c8
Compare
Sorry for the number of commits on this one. Had to reconcile history tree between my branch and yours. |
@lukasoppermann - hey |
Merged
Closing as replaced by #494 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
sortenter
event - useful when dragging to a different list and wish to update placeholder content.sortstart
andsortenter
event. When sortable is used with copy = true, the dragged item is a deep-copy of the original target. This prevents accessing the real original target. This is a problem in some cases (like in polymer dom-repeat component) where only the original target holds some linked properties.