Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow handle in shadowRoot #488

Merged

Conversation

christophe-g
Copy link
Contributor

Closes #487

Adaptations required to allow handle in shadowRoot:

Tests are passing, no time not to write new test for this feature.

In case you are interested, I can PR a Polymer 2.0 port (actually rewrite) of https://github.com/rodrigosancho/polymer-html5sortable that would contain a demo testing this new feature.

@coveralls
Copy link

coveralls commented Feb 22, 2019

Coverage Status

Coverage decreased (-1.06%) to 6.944% when pulling 804ef8b on christophe-g:support-shadowroot-handlers into 872e0ce on lukasoppermann:master.

@lukasoppermann
Copy link
Owner

Hey, yes please send a polymer 2 port. 👍

@christophe-g
Copy link
Contributor Author

Hey, yes please send a polymer 2 port.

Cool, I'll do that early next week.

@lukasoppermann
Copy link
Owner

Hey, can you do me a favor and remove all compiled files from the PR? So send only the ones in src. I thought I could delete them from the PR but this is actually saying a "delete this file".

Thanks.

@christophe-g
Copy link
Contributor Author

@lukasoppermann - sure.

Should build files not be git-ignored ?

@lukasoppermann
Copy link
Owner

Thanks.

Well the issue with .gitignore is that I need to be able to push those file to master when doing a new release.

I know of no way to ignore files but let me push them to master. 😞

@christophe-g
Copy link
Contributor Author

@lukasoppermann - understood.

I am not an npm expert, but I think you can whitelist files that need to be included in the release package by adding :

“files”: [“build/**/*”]

in package.json, and still let git ignore them (https://itnext.io/step-by-step-building-and-publishing-an-npm-typescript-package-44fe7164964c)

@lukasoppermann
Copy link
Owner

Ahh, so you are saying never push them to master but add them to npm? I'll investigate that. 👍

@lukasoppermann
Copy link
Owner

Hey @christophe-g could you update the PR so I can merge it? Thanks.

@christophe-g christophe-g force-pushed the support-shadowroot-handlers branch from e33e52c to be6d7f9 Compare March 1, 2019 14:51
@christophe-g christophe-g mentioned this pull request Mar 1, 2019
@lukasoppermann lukasoppermann merged commit bd66a3e into lukasoppermann:master Mar 1, 2019
lukasoppermann pushed a commit that referenced this pull request Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants