-
-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow handle in shadowRoot #488
allow handle in shadowRoot #488
Conversation
Hey, yes please send a polymer 2 port. 👍 |
Cool, I'll do that early next week. |
Hey, can you do me a favor and remove all compiled files from the PR? So send only the ones in Thanks. |
@lukasoppermann - sure. Should build files not be git-ignored ? |
Thanks. Well the issue with I know of no way to ignore files but let me push them to master. 😞 |
@lukasoppermann - understood. I am not an npm expert, but I think you can whitelist files that need to be included in the release package by adding :
in package.json, and still let git ignore them (https://itnext.io/step-by-step-building-and-publishing-an-npm-typescript-package-44fe7164964c) |
Ahh, so you are saying never push them to master but add them to npm? I'll investigate that. 👍 |
Hey @christophe-g could you update the PR so I can merge it? Thanks. |
e33e52c
to
be6d7f9
Compare
Closes #487
Adaptations required to allow handle in shadowRoot:
getEventTarget
method.event.composedPath()
infindSortable
instead of looping up dom tree to find sortable.Tests are passing, no time not to write new test for this feature.
In case you are interested, I can PR a Polymer 2.0 port (actually rewrite) of https://github.com/rodrigosancho/polymer-html5sortable that would contain a demo testing this new feature.