Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aliased variables variables with tests #300

Merged
merged 14 commits into from
Jun 26, 2024
Merged

Fix aliased variables variables with tests #300

merged 14 commits into from
Jun 26, 2024

Conversation

JackHowa
Copy link
Contributor

@JackHowa JackHowa closed this Jan 18, 2024
@coveralls
Copy link

coveralls commented Jan 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9677656577

Details

  • 25 of 38 (65.79%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+10.1%) to 76.548%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/utilities/getVariables.ts 6 19 31.58%
Totals Coverage Status
Change from base Build 8422990754: 10.1%
Covered Lines: 577
Relevant Lines: 738
💛 - Coveralls

@JackHowa JackHowa reopened this Jun 26, 2024
JackHowa
JackHowa commented Jun 26, 2024
View reviewed changes
src/transformer/standardTransformer.ts
@@ -4,7 +4,7 @@ import { StandardTokenInterface, StandardTokenTypes, StandardTokenDataInterface,
import roundWithDecimals from '../utilities/roundWithDecimals'
import { tokenExtensions } from './tokenExtensions'
import config from '@config/config'
import { changeNotation } from '@src/utilities/changeNotation'
import { changeNotation } from '../utilities/changeNotation'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had to update syntax so tests would recognize origin of mapping

@JackHowa JackHowa marked this pull request as ready for review June 26, 2024 10:05
@JackHowa JackHowa mentioned this pull request Jun 26, 2024
Open
@lukasoppermann lukasoppermann merged commit 2861fa9 into lukasoppermann:main Jun 26, 2024
2 checks passed
@JackHowa JackHowa mentioned this pull request Jun 26, 2024
Closed
@f-Keith f-Keith mentioned this pull request Jul 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JackHowa @coveralls @lukasoppermann