Winter cleanup #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasmalkmus
force-pushed
the
winter-cleanup
branch
from
44095b6
to
b31bcef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings some enhancements to the exporter.
It breaks with the tradition of using the official prometheus tooling for building and releasing this exporter. While the official tooling is nice for maintaining a larger set of exporters (e.g. the official ones), it is hard to maintain all that. I now use my own workflows/tools I know to test, build and release the exporter.
Furthermore, station details are now in their own static metric and can be joined, in case more than the station ID is needed.