Update example to work with resolver 2 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaslueg
reviewed
Sep 11, 2021
example_project/Cargo.toml
Outdated
| @@ -4,9 +4,10 @@ version = "0.1.0" | |||
| authors = ["Lukas Lueg <lukas.lueg@gmail.com>"] | |||
| build = "build.rs" | |||
| edition = "2018" | |||
| resolver = "2" | |||
There was a problem hiding this comment.
What about backward compatibility here? We can just set the features explicitly for the build-time dependency without referring to the resolver-key
|
Sure, it's not needed, I removed it. It builds with 1.48.0.
…On Saturday 11 September 2021 16:57:08 EDT, lukaslueg wrote:
@lukaslueg commented on this pull request.
> @@ -4,9 +4,10 @@ version = "0.1.0"
authors = ["Lukas Lueg ***@***.***>"]
build = "build.rs"
edition = "2018"
+resolver = "2"
What about backward compatibility here? We can just set the features
explicitly for the build-time dependency without referring to the
`resolver`-key
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#43 (review)
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
resolver = "2"(default in 2021 Edition), features need to be specified explicitly for build dependencies, otherwise whenbuild.rsis run, it doesn't generate feature-gated values.