Draft: feat: offset column by inlay hints #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! This PR is not fully finished (should probably check a bit more cases and make it an opt-in/opt-out config), but wanted to see if you have any initial thoughts if this could make sense. Sometimes I work with LSPs that support inlay hints (
rustorbasedpyright) and then the column width is not really useful anymore to know if the lines are actually longer than some number of characters. So in this PR we offset the column by how many virtual characters there are in the line (before the last real character), see screenshot below, just some dummy code.I'm not fully sure what's the best way to handle virtual text after the last real character. The column width should obviously not be corrected by these but what I'm wondering is what should take precedence? Do you always want to see the column width. In my case I think I would. But not actually sure how to make sure that's "on top".