CI probe: leaf isDomainError only (do not merge) - #313
Closed
lukas-grigis wants to merge 2 commits into
Closed
Conversation
- assert non-ENOENT/ENOTDIR stat failures surface as ErrorCode.Storage (subCode io), not the raw errno - raw errno preserved on .cause; exercised via a real self-referential .git symlink (ELOOP), no fs mocks Claude-Session: https://claude.ai/code/session_01PHikH4LdejozJdjzTzhPes
…293) - isDomainError now checks exact ErrorCode membership, not 'Error with a string code' - errno throws (EACCES, ELOOP) re-propagate to the runner's containment boundary; trade-off: the synthesized failure names the root element, not the leaf - compile-time fence: Exclude<DomainError['code'], ErrorCode> must stay never - AbortError handling unchanged Claude-Session: https://claude.ai/code/session_01PHikH4LdejozJdjzTzhPes
Owner
Author
|
Probe done — #293 leaf change exonerated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bisect probe for the #311 per-card-toggle CI failure: main + #293 commits only.
https://claude.ai/code/session_01PHikH4LdejozJdjzTzhPes