fix: maintenance-council hardening sweep - #307
Merged
Merged
Conversation
- chain: in-branch AbortError now stops wave scheduling; propagates verbatim - providers: two-tier rate-limit detection (no prose false-positives), landed signals.json beats stdout evidence, unreachable model ids fail fast - security: worktree git-exclude resolves commondir; skill-suggestion names sanitized against path traversal - task: diff-scoped verify no longer stamps full-tree baseline, evaluator crashes retry within maxAttempts, unblock clears best-of-N grants - tui: router.reset requires explicit entry (no preset re-stamp), blocked tasks bucketed as skipped, nested-runner token usage keyed on root session, overlays hard-wrap before windowing, esc/dismiss key gating fixed - release: hermetic vitest color env, CLI top-level error handler, pack+install smoke before npm publish, bundled-prompt resolver gate in CI - tests: one loud waitFor contract (exposed 2 dead tests), real pull-request-creator coverage, forensics negatives await loaded state - docs: four-backend drift, contributor guide, data-model fields, implementFlow trace, README CLI reference, playbook scenarios for Unreleased features Claude-Session: https://claude.ai/code/session_01PHikH4LdejozJdjzTzhPes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-release hardening batch from a full-repo maintenance audit: 8 auditor roles (correctness, TUI/display, chain framework, provider adapters, release gates, test integrity, security, docs drift) produced 51 findings, deduplicated to 47; every must/should candidate was adversarially re-verified against the code before implementation. 28 verified findings are fixed here; 19 lower-severity ones were filed as issues #288–#306.
Must-fixes
signals.jsonand sleep ~36 min); landed signals now beat stdout evidence; unreachable OpenCode model ids fail fast instead of burning the attempt budget.git/info/excludenow resolves the common git dir (bundled skills were being committed); AI-suppliedskill-suggestionsnames are sanitized against path traversal at the contract boundaryrouter.resetrequires an explicit entry — first-runh/Dno longer bounce to Welcome and re-stamp the AI preset; document overlays hard-wrap before windowing so wrapped critiques scroll correctlyFORCE_COLOR=0—pnpm testwas reporting 27 false failures whenever the caller's shell exported FORCE_COLORShould-fixes
regressedblocks)maxAttemptsinstead of terminally blocking the task;unblockTaskclears best-of-N grant stampsralphctl prompts listwaitForcontract across the TUI suite (exposed and fixed 2 silently-dead tests); real coverage forpull-request-creator; forensics negative tests await loaded state; entropy-check fixtures match the real loop compositionVerification
pnpm typecheck/pnpm lint/pnpm testall green — 607 files / 5890 tests (+18 files, +131 tests), passing withFORCE_COLOR=3exported (previously 27 false failures)pnpm build,pnpm deadcode,pnpm format:checkclean; every fix ships with a regression test written to fail firsthttps://claude.ai/code/session_01PHikH4LdejozJdjzTzhPes