Delete failure cache key when circuit opens #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 11 11
Lines 153 154 +1
=====================================
+ Hits 153 154 +1
Continue to review full report at Codecov.
|
jairhenrique
approved these changes
Aug 23, 2017
renanivo
reviewed
Aug 23, 2017
|
|
||
| def _increase_failure_count(self): | ||
| # Between the cache.add and cache.incr, the cache MAY expire, | ||
| # which will led to a circuit that will eventually open |
Contributor
There was a problem hiding this comment.
Isn't it ...will lead instead of will led?
This is to mitigate the consequences from a key that may be created without timeout. It may occur when a key expires AFTER the `add` call and it's created in the `incr`, therefore without timeout.
RomuloOliveira
force-pushed
the
ro-circuit_breaker_race_condition-fix
branch
from
ddc352e to
21f5615
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to mitigate the consequences from a key that may be created without timeout. It may occur when a key expires AFTER the
addcall and it's created in theincr, therefore without timeout.