Skip to content

Added check if FB SDK has already loaded on page, otherwise fbAsyncInit ... #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dreamoftrees wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added check if FB SDK has already loaded on page, otherwise fbAsyncInit ... #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1073192
Added check if FB SDK has already loaded on page, otherwise fbAsyncIn…
dreamoftrees Mar 20, 2015
990f48b
Merge branch 'master' of github.com:dreamoftrees/angular-facebook int…
dreamoftrees Nov 3, 2015
7a56b08
Rebuild dist
dreamoftrees Nov 3, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ local.properties
.classpath
.settings/
.loadpath
.idea/

# External tool builders
.externalToolBuilders/
Expand Down
85 changes: 46 additions & 39 deletions dist/angular-facebook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,48 +469,55 @@
delete(settings['loadSDK']); // Remove loadSDK from settings since this isn't part from Facebook API.

/**
* Define fbAsyncInit required by Facebook API
*/
$window.fbAsyncInit = function() {
// Initialize our Facebook app
$timeout(function() {
if (!settings.appId) {
throw 'Missing appId setting.';
}

FB.init(settings);

flags.ready = true;

/**
* Subscribe to Facebook API events and broadcast through app.
*/
angular.forEach({
'auth.login': 'login',
'auth.logout': 'logout',
'auth.prompt': 'prompt',
'auth.sessionChange': 'sessionChange',
'auth.statusChange': 'statusChange',
'auth.authResponseChange': 'authResponseChange',
'xfbml.render': 'xfbmlRender',
'edge.create': 'like',
'edge.remove': 'unlike',
'comment.create': 'comment',
'comment.remove': 'uncomment'
}, function(mapped, name) {
FB.Event.subscribe(name, function(response) {
$timeout(function() {
$rootScope.$broadcast('Facebook:' + mapped, response);
});
* Define fbAsyncInit required by Facebook API
*/
function init() {
// Initialize our Facebook app
$timeout(function() {
if (!settings.appId) {
throw 'Missing appId setting.';
}

FB.init(settings);

// Set ready global flag
flags.ready = true;

/**
* Subscribe to Facebook API events and broadcast through app.
*/
angular.forEach({
'auth.login': 'login',
'auth.logout': 'logout',
'auth.prompt': 'prompt',
'auth.sessionChange': 'sessionChange',
'auth.statusChange': 'statusChange',
'auth.authResponseChange': 'authResponseChange',
'xfbml.render': 'xfbmlRender',
'edge.create': 'like',
'edge.remove': 'unlike',
'comment.create': 'comment',
'comment.remove': 'uncomment'
}, function(mapped, name) {
FB.Event.subscribe(name, function(response) {
$timeout(function() {
$rootScope.$broadcast('Facebook:' + mapped, response);
});
});
});
});

// Broadcast Facebook:load event
$rootScope.$broadcast('Facebook:load');
// Broadcast Facebook:load event
$rootScope.$broadcast('Facebook:load');

loadDeferred.resolve(FB);
});
};
loadDeferred.resolve(FB);
});
}
// Check if FB SDK has already loaded
if(typeof $window.FB !== 'undefined') {
init();
} else {
$window.fbAsyncInit = init;
}

/**
* Inject Facebook root element in DOM
Expand Down
2 changes: 1 addition & 1 deletion dist/angular-facebook.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

85 changes: 46 additions & 39 deletions lib/angular-facebook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,48 +469,55 @@
delete(settings['loadSDK']); // Remove loadSDK from settings since this isn't part from Facebook API.

/**
* Define fbAsyncInit required by Facebook API
*/
$window.fbAsyncInit = function() {
// Initialize our Facebook app
$timeout(function() {
if (!settings.appId) {
throw 'Missing appId setting.';
}

FB.init(settings);

flags.ready = true;

/**
* Subscribe to Facebook API events and broadcast through app.
*/
angular.forEach({
'auth.login': 'login',
'auth.logout': 'logout',
'auth.prompt': 'prompt',
'auth.sessionChange': 'sessionChange',
'auth.statusChange': 'statusChange',
'auth.authResponseChange': 'authResponseChange',
'xfbml.render': 'xfbmlRender',
'edge.create': 'like',
'edge.remove': 'unlike',
'comment.create': 'comment',
'comment.remove': 'uncomment'
}, function(mapped, name) {
FB.Event.subscribe(name, function(response) {
$timeout(function() {
$rootScope.$broadcast('Facebook:' + mapped, response);
});
* Define fbAsyncInit required by Facebook API
*/
function init() {
// Initialize our Facebook app
$timeout(function() {
if (!settings.appId) {
throw 'Missing appId setting.';
}

FB.init(settings);

// Set ready global flag
flags.ready = true;

/**
* Subscribe to Facebook API events and broadcast through app.
*/
angular.forEach({
'auth.login': 'login',
'auth.logout': 'logout',
'auth.prompt': 'prompt',
'auth.sessionChange': 'sessionChange',
'auth.statusChange': 'statusChange',
'auth.authResponseChange': 'authResponseChange',
'xfbml.render': 'xfbmlRender',
'edge.create': 'like',
'edge.remove': 'unlike',
'comment.create': 'comment',
'comment.remove': 'uncomment'
}, function(mapped, name) {
FB.Event.subscribe(name, function(response) {
$timeout(function() {
$rootScope.$broadcast('Facebook:' + mapped, response);
});
});
});
});

// Broadcast Facebook:load event
$rootScope.$broadcast('Facebook:load');
// Broadcast Facebook:load event
$rootScope.$broadcast('Facebook:load');

loadDeferred.resolve(FB);
});
};
loadDeferred.resolve(FB);
});
}
// Check if FB SDK has already loaded
if(typeof $window.FB !== 'undefined') {
init();
} else {
$window.fbAsyncInit = init;
}

/**
* Inject Facebook root element in DOM
Expand Down